Re: [PATCH 1/2]: Add support for Dallas/Maxim DS1685/1687 RTC

[Kumba <kumba@gentoo.org>]

On 02/17/2011 06:43, Lars-Peter Clausen wrote:
> That is what I meant. Pass the return value of rtc_valid_tm on, instead of
> setting the time to 0 and pretend everything went fine.
> You can still keep the dev_err though, no problem with that.
Okay, I got confused by this and thought you were referring to the quoted test 
box below in your first response.  My bad.  You're referring to the tail end of 
ds1685_rtc_read_time.
To clarify, this construct exists in four existing RTC drivers.  If this is 
wrong, I suggest fixing these four drivers, lest someone else come along and try 
to copy the idea, thinking it's the RightThing();
        drivers/rtc/rtc-ds1553.c:131
        drivers/rtc/rtc-ds1742.c:119
        drivers/rtc/rtc-rs5c348.c:136
        drivers/rtc/rtc-stk17ta8.c:133

I am going to assume the proper approach is:
        return rtc_Valid_tm(tm);


Cheers!,

--
Joshua Kinard
Gentoo/MIPS
kumba@gentoo.org

"The past tempts us, the present confuses us, the future frightens us.  And our 
lives slip away, moment by moment, lost in that vast, terrible in-between."
--Emperor Turhan, Centauri Republic