Re: [PATCH] MIPS: Octeon: Kconfig: fix helper dependency

[David Daney <ddaney@caviumnetworks.com>]

On 02/17/2011 06:28 AM, Antony Pavlov wrote:
> The option CAVIUM_OCTEON_HELPER does not depend
> on CPU_CAVIUM_OCTEON option.
> So my .config file for MIPS Malta board contains
>
>   CONFIG_MIPS_MALTA=y
>   ...
>   # CONFIG_CAVIUM_OCTEON_SIMULATOR is not set
>   # CONFIG_CAVIUM_OCTEON_REFERENCE_BOARD is not set
>   ...
>   CONFIG_CAVIUM_OCTEON_HELPER=y
>
> Signed-off-by: Antony Pavlov<antonynpavlov@gmail.com>
NAK.

I have a patch that takes a different approach.

David Daney


> ---
>   arch/mips/cavium-octeon/Kconfig |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/mips/cavium-octeon/Kconfig b/arch/mips/cavium-octeon/Kconfig
> index caae228..a6a2f3c 100644
> --- a/arch/mips/cavium-octeon/Kconfig
> +++ b/arch/mips/cavium-octeon/Kconfig
> @@ -97,7 +97,7 @@ config ARCH_SPARSEMEM_ENABLE
>
>   config CAVIUM_OCTEON_HELPER
>         def_bool y
> -       depends on OCTEON_ETHERNET || PCI
> +       depends on CPU_CAVIUM_OCTEON&&  (OCTEON_ETHERNET || PCI)
>
>   config IOMMU_HELPER
>         bool