linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Octeon: Kconfig: fix helper dependency

To: Antony Pavlov <antonynpavlov@gmail.com>
Subject: Re: [PATCH] MIPS: Octeon: Kconfig: fix helper dependency
From: David Daney <ddaney@caviumnetworks.com>
Date: Thu, 17 Feb 2011 10:01:02 -0800
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
In-reply-to: <1297952906-1099-1-git-send-email-antonynpavlov@gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1297952906-1099-1-git-send-email-antonynpavlov@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10
On 02/17/2011 06:28 AM, Antony Pavlov wrote:
The option CAVIUM_OCTEON_HELPER does not depend
on CPU_CAVIUM_OCTEON option.
So my .config file for MIPS Malta board contains

  CONFIG_MIPS_MALTA=y
  ...
  # CONFIG_CAVIUM_OCTEON_SIMULATOR is not set
  # CONFIG_CAVIUM_OCTEON_REFERENCE_BOARD is not set
  ...
  CONFIG_CAVIUM_OCTEON_HELPER=y

Signed-off-by: Antony Pavlov<antonynpavlov@gmail.com>

NAK.

I have a patch that takes a different approach.

David Daney


---
  arch/mips/cavium-octeon/Kconfig |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/mips/cavium-octeon/Kconfig b/arch/mips/cavium-octeon/Kconfig
index caae228..a6a2f3c 100644
--- a/arch/mips/cavium-octeon/Kconfig
+++ b/arch/mips/cavium-octeon/Kconfig
@@ -97,7 +97,7 @@ config ARCH_SPARSEMEM_ENABLE

  config CAVIUM_OCTEON_HELPER
        def_bool y
-       depends on OCTEON_ETHERNET || PCI
+       depends on CPU_CAVIUM_OCTEON&&  (OCTEON_ETHERNET || PCI)

  config IOMMU_HELPER
        bool


<Prev in Thread] Current Thread [Next in Thread>