linux-mips
[Top] [All Lists]

Re: [PATCH] ath5k: Use mips generic dma-mapping functions to avoid seqfa

To: Jiri Slaby <jirislaby@gmail.com>
Subject: Re: [PATCH] ath5k: Use mips generic dma-mapping functions to avoid seqfault on AHB chips
From: Ralf Baechle <ralf@linux-mips.org>
Date: Wed, 16 Feb 2011 02:12:03 +0100
Cc: Nikolay Ledovskikh <nledovskikh@gmail.com>, "John W. Linville" <linville@tuxdriver.com>, linux-wireless@vger.kernel.org, lrodriguez@atheros.com, mickflemm@gmail.com, me@bobcopeland.com, linux-mips@linux-mips.org
In-reply-to: <4D5AFBCB.1090907@gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20110215220929.1cc6e9d4.nledovskikh@gmail.com> <4D5AD6A6.8090505@gmail.com> <AANLkTiks9rG2CzM2LabNerK3zgJ+R+weytQgvXxDbNe7@mail.gmail.com> <4D5AE52B.80002@gmail.com> <AANLkTinnCOEXF835yhNeJDfBdKjx_dss6TFeUmjL-Yk2@mail.gmail.com> <4D5AFB3B.6080407@gmail.com> <4D5AFBCB.1090907@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Feb 15, 2011 at 11:18:51PM +0100, Jiri Slaby wrote:

> > There, the res->start may be either of the following:
> > AR531X_WLAN0 .. 0x18000000
> > AR531X_WLAN1 .. 0x18500000
> 
> 
> > AR2315_WLAN0 .. 0xB0000000
> 
> Or maybe this should be 0x10000000 in openwrt in the first place? Then
> ioremap should do the right thing, right?

Yes - 0xb0000000 looks like it's a virtual address which is wrong.

Rule #1: Put physical addresses in headers and code only.
Rule #2: If using one of the KSEG address and address conversion macros,
get rid of them, use ioremap.  The KSEG macros are for use by arch core
code only; for use anywhere else I reject patches these days.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>