Re: [PATCH] ath5k: Use mips generic dma-mapping functions to avoid seqfault on AHB chips

[Ralf Baechle <ralf@linux-mips.org>]

On Tue, Feb 15, 2011 at 11:18:51PM +0100, Jiri Slaby wrote:

> > There, the res->start may be either of the following:
> > AR531X_WLAN0 .. 0x18000000
> > AR531X_WLAN1 .. 0x18500000
> 
> 
> > AR2315_WLAN0 .. 0xB0000000
> 
> Or maybe this should be 0x10000000 in openwrt in the first place? Then
> ioremap should do the right thing, right?

Yes - 0xb0000000 looks like it's a virtual address which is wrong.

Rule #1: Put physical addresses in headers and code only.
Rule #2: If using one of the KSEG address and address conversion macros,
get rid of them, use ioremap.  The KSEG macros are for use by arch core
code only; for use anywhere else I reject patches these days.

  Ralf