linux-mips
[Top] [All Lists]

Re: [v2 PATCH 5/5] tracing, MIPS: Fix set_graph_function of function gra

To: Sergei Shtylyov <sshtylyov@mvista.com>
Subject: Re: [v2 PATCH 5/5] tracing, MIPS: Fix set_graph_function of function graph tracer
From: wu zhangjin <wuzhangjin@gmail.com>
Date: Sat, 22 Jan 2011 02:00:27 +0800
Cc: Ralf Baechle <ralf@linux-mips.org>, Steven Rostedt <srostedt@redhat.com>, linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=3XZDYq+O5NsATQqR6HMKj64/XtU/NsaRr/BPBGK7dCE=; b=HsqPEfdpCDCHTyIDqEc87G6plMOK4h/SU+BQxncR6zm1P5lrZsN5YeV0IZhvQWEN4t iAqoCALb72EXMb3ACE31dmeLlC/0F5AmffDXk60k4kccdMY/71IJCER52n4422GFFpJe neSeqEvbYXkd0GdXrTomhOgGbsICQu+NNv0IU=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=TXoPoWpZYPkRH/3rltnWugVHLLkiy8oUCyHeyVba/1jzKft7MpGeXH+JkY91rCKlRd 6dn1mKprh52f97hPsgbyhbmq/UPUJqSBobccTKkL6njtuk8HNZrWWUCqmnr7QVMlsle4 5+KWEj+F6tkrmxwCcTSJyOuqqNVTjnVHUUHnU=
In-reply-to: <4D39C3ED.4020401@mvista.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1295630970-32044-1-git-send-email-wuzhangjin@gmail.com> <4D39C3ED.4020401@mvista.com>
Sender: linux-mips-bounce@linux-mips.org
On Sat, Jan 22, 2011 at 1:35 AM, Sergei Shtylyov <sshtylyov@mvista.com> wrote:
>> +
>> +       insns = (in_kernel_space(self_ra)) ? 2 : MCOUNT_OFFSET_INSNS + 1;
>
>   You're still keeping the parens around the function call. Why? :-)

I even didn't notice there was parens there, may be parens mania, new
one will be out immediately ;-)

>
> WBR, Sergei
>

<Prev in Thread] Current Thread [Next in Thread>