linux-mips
[Top] [All Lists]

Re: [PATCH 2/2] MIPS: Optimize TLB handlers for Octeon CPUs

To: David Daney <ddaney@caviumnetworks.com>
Subject: Re: [PATCH 2/2] MIPS: Optimize TLB handlers for Octeon CPUs
From: Jonas Gorski <jonas.gorski@gmail.com>
Date: Wed, 19 Jan 2011 20:46:19 +0100
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type:content-transfer-encoding; bh=3tXBhO7dnchyZaEGy8j+UCcE3x5SsURpM7bkBkeX414=; b=GSBzoZzVAi72XBgqQYfENWFnf3a4Uvx43jy0EXJmLG8sHK+CQXzQPL5G6TyDHKFtAV 8IIq5zncBh+dY8rO4nt/7S5nSuHoa/p0vR7KYLpzdDH7EmlXQhabi6HIhRh4sNJbOJ9c Dm/IcRrYo5OyjLxWrz67zyD+Uz+Wh7RTGTUSg=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=XDhz6Sfc3FdLZZEuxQRNamdMMcN16Y0Ued84RCz6GkrhddF8uMRWA700y0u59KplPl n44cHLumhJ/KV4Qh2xu4SnoNxBUwGzcveM8BOaqvitP//oCNPo1WAdgIy/gvbGnm0JOm bzRVJSKvE0SwMoexFCDGg/Jl7J0dM7EaR6g6s=
In-reply-to: <4D373E5B.5010303@caviumnetworks.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1293502077-9196-1-git-send-email-ddaney@caviumnetworks.com> <1293502077-9196-3-git-send-email-ddaney@caviumnetworks.com> <AANLkTinZZ2TziwkiBfhqV-3-VfXwU+EPx3OHsnTRVChT@mail.gmail.com> <4D373E5B.5010303@caviumnetworks.com>
Sender: linux-mips-bounce@linux-mips.org
On 19 January 2011 20:41, David Daney <ddaney@caviumnetworks.com> wrote:
> On 01/19/2011 11:35 AM, Jonas Gorski wrote:
>>
>> On 28/12/2010, David Daney<ddaney@caviumnetworks.com>  wrote:
>>>
>>> +#if defined(CONFIG_CAVIUM_OCTEON_CVMSEG_SIZE)&&  \
>>> +    CONFIG_CAVIUM_OCTEON_CVMSEG_SIZE>  0
>>> (...)
>>> +#else
>>> +static bool scratchpad_available(void)
>>> +{
>>> +       return false;
>>> +}
>>> +static int scratchpad_offset(int i)
>>> +{
>>> +       BUG();
>>> +}
>>> +#endif
>>
>> This seems to have broken the build for any non-octeon mips build:
>>
>>   CC      arch/mips/mm/tlbex.o
>> cc1: warnings being treated as errors
>> arch/mips/mm/tlbex.c: In function 'scratchpad_offset':
>> arch/mips/mm/tlbex.c:112: error: no return statement in function
>> returning non-void
>>
>
> Can you tell me which version of GCC you are using?
>
> I tested it with gcc-4.5.x, BUG() may have problems if builtin_unreachable
> is not available.

That's probably it, It's a 4.3.3 (with code sourcery extensions, the
OpenWrt default one).

Jonas

<Prev in Thread] Current Thread [Next in Thread>