linux-mips
[Top] [All Lists]

Re: [PATCH 2/2] MIPS: Optimize TLB handlers for Octeon CPUs

To: David Daney <ddaney@caviumnetworks.com>
Subject: Re: [PATCH 2/2] MIPS: Optimize TLB handlers for Octeon CPUs
From: Jonas Gorski <jonas.gorski+openwrt@gmail.com>
Date: Wed, 19 Jan 2011 20:35:43 +0100
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=l3do2g7UFAYJ4sofgcftQNprh/1Ujv/h/7ZEJnZo8+I=; b=wMjl4rjGvPHbsyFYHZIfhMEA3Yz5TTYxqsy4dkxI8id+IT8vWXTwN18UOYwv+xcpTk UCcvsMqpfL8LjI9kTPijXGYfV7Ts1m4No9rWKWJwFovXgQDquazAmYaxxi6y+QYyQUev vzB4rjj3RsgMCeHlv4SZibNPsPIIMcTXayWFc=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; b=ZE9TRJ+w1jH5x5jxqFGmx6EWAuXvWnC/N6u5cgUatv/zud9yefukTryXn7mseroIJ3 cza6tID8pucibZr9u9Q57x1aiXsGVp2/0GA3aaVdamWtPWwEj+c8xnppH5iX3nUzhBHm rd5rB2G6rU6i5Ww3gkiMFo7D00ZgBRd44+UC0=
In-reply-to: <1293502077-9196-3-git-send-email-ddaney@caviumnetworks.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1293502077-9196-1-git-send-email-ddaney@caviumnetworks.com> <1293502077-9196-3-git-send-email-ddaney@caviumnetworks.com>
Sender: linux-mips-bounce@linux-mips.org
On 28/12/2010, David Daney <ddaney@caviumnetworks.com> wrote:
> +#if defined(CONFIG_CAVIUM_OCTEON_CVMSEG_SIZE) && \
> +    CONFIG_CAVIUM_OCTEON_CVMSEG_SIZE > 0
> (...)
> +#else
> +static bool scratchpad_available(void)
> +{
> +     return false;
> +}
> +static int scratchpad_offset(int i)
> +{
> +     BUG();
> +}
> +#endif

This seems to have broken the build for any non-octeon mips build:

  CC      arch/mips/mm/tlbex.o
cc1: warnings being treated as errors
arch/mips/mm/tlbex.c: In function 'scratchpad_offset':
arch/mips/mm/tlbex.c:112: error: no return statement in function
returning non-void

Regards,
Jonas

<Prev in Thread] Current Thread [Next in Thread>