linux-mips
[Top] [All Lists]

Re: [PATCH 1/2] MIPS: add CONFIG_VIRTUALIZATION for virtio support

To: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [PATCH 1/2] MIPS: add CONFIG_VIRTUALIZATION for virtio support
From: Christoph Hellwig <hch@lst.de>
Date: Wed, 19 Jan 2011 15:30:49 +0100
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
In-reply-to: <1295349645-16805-1-git-send-email-aurelien@aurel32.net>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1295349645-16805-1-git-send-email-aurelien@aurel32.net>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.3.28i
On Tue, Jan 18, 2011 at 12:20:44PM +0100, Aurelien Jarno wrote:
> Add CONFIG_VIRTUALIZATION to the MIPS architecture and include the
> the virtio code there. Used to enable the virtio drivers under QEMU.
> 
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
>  arch/mips/Kconfig |   16 ++++++++++++++++

> +menuconfig VIRTUALIZATION
> +     bool "Virtualization"
> +     default n
> +     ---help---
> +       Say Y here to get to see options for using your Linux host to run 
> other
> +       operating systems inside virtual machines (guests).
> +       This option alone does not add any kernel code.
> +
> +       If you say N, all options in this submenu will be skipped and 
> disabled.

This item seems rather misleading as you're using virtio drivers as a
guest.  I think the right fix is to just remove the VIRTUALIZATION
dependency for the qemu drivers and just include them from
drivers/Kconfig for all architectures.  There aren't a whole lot Linux
architectures that don't have a qemu emulation these days.


<Prev in Thread] Current Thread [Next in Thread>