linux-mips
[Top] [All Lists]

Re: [PATCH 01/10] MIPS: lantiq: add initial support for Lantiq SoCs

To: Daniel Schwierzeck <daniel.schwierzeck@googlemail.com>
Subject: Re: [PATCH 01/10] MIPS: lantiq: add initial support for Lantiq SoCs
From: John Crispin <blogic@openwrt.org>
Date: Thu, 13 Jan 2011 16:03:22 +0100
Cc: Ralf Baechle <ralf@linux-mips.org>, Ralph Hempel <ralph.hempel@lantiq.com>, linux-mips@linux-mips.org
In-reply-to: <AANLkTingxSonua3v+9rqCJeuV-TjiMBX_BfxxHYOcBoe@mail.gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1294257379-417-1-git-send-email-blogic@openwrt.org> <1294257379-417-2-git-send-email-blogic@openwrt.org> <AANLkTinBovWsPak3cCNRMigC8mxUwEik2oB3kSsw-YQL@mail.gmail.com> <4D2EDE92.40203@openwrt.org> <AANLkTingxSonua3v+9rqCJeuV-TjiMBX_BfxxHYOcBoe@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.12) Gecko/20100913 Icedove/3.0.7
On 13/01/11 13:47, Daniel Schwierzeck wrote:
> Hi John,
>
> 2011/1/13 John Crispin <blogic@openwrt.org>:
>   
>>     
>>>> +
>>>> +/* all access to the ebu must be locked */
>>>> +DEFINE_SPINLOCK(ebu_lock);
>>>> +EXPORT_SYMBOL_GPL(ebu_lock);
>>>>
>>>>         
>>> This lock is only needed if you want to use software arbitration.
>>> Normally the EBU does hardware arbitration and can be accessed safely
>>> without lock.
>>>
>>>
>>>       
>> openwrt borks up on mini_fo init when this lock is not in-place. we saw
>> a lot of issues in the past which lead to this lock being added. i will
>> retry it with out the lock to verify
>>
>>     
> Ok I never tried mini_fo bit it's working fine with squashfs. Maybe
> it's a problem with your EBU setup. We always reset
> the EBU_ADDR_SEL0 and EBU_CON_0 registers in U-Boot's lowlevel_init.S.
> The values are EBU_ADDR_SEL0 = 0x10000021
> and EBU_CON_0 = 0x8001F7FF.
> My suggestion is to wrap the locking mechanism into separate inline
> functions and define them only if really needed and enabled in kernel
> config.
>
> Daniel
>
>
>   
Ok, i will try with those values to see if the EBU is setup incorrectly,
thx for the pointers !


<Prev in Thread] Current Thread [Next in Thread>