linux-mips
[Top] [All Lists]

Re: [PATCH 01/10] MIPS: lantiq: add initial support for Lantiq SoCs

To: John Crispin <blogic@openwrt.org>
Subject: Re: [PATCH 01/10] MIPS: lantiq: add initial support for Lantiq SoCs
From: Daniel Schwierzeck <daniel.schwierzeck@googlemail.com>
Date: Thu, 13 Jan 2011 13:47:40 +0100
Cc: Ralf Baechle <ralf@linux-mips.org>, Ralph Hempel <ralph.hempel@lantiq.com>, linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=RXZJuMfdD8EkWwPl1PVMWK1bQxAyMuZ9Kfkdz0/hTyc=; b=NU9aP++D8dokvwZnGN3Ln05WXGfL8db0gYJMSBdwkueFek3YvutdIc41EL5lv80bN2 VSxnPNBfyIj+CmJdhVJrM78Qh0LCGAR7DeUgd+9jAh+TR9XysT+31m7tdNUwS8iOCZcG p7h0X0OUavVTMzioocosIo6FOHrXaVkNdXo9k=
Domainkey-signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=ffWSbxuDMx332otJsVRI2ZTbqxaMBnWWDlO4G+XCGPAru3zDJxTfRSUsCz3oRPr1NJ 9ao+zywaO9NNGiUW3hmhFRRDF5i4ZBZZ/LLP5zLFrTUiT+81rv8MNY7p6WCxzfRlnH4V SKo7HkCVFlC6MgRL+XDshs8waIYaaO9jRYGgw=
In-reply-to: <4D2EDE92.40203@openwrt.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1294257379-417-1-git-send-email-blogic@openwrt.org> <1294257379-417-2-git-send-email-blogic@openwrt.org> <AANLkTinBovWsPak3cCNRMigC8mxUwEik2oB3kSsw-YQL@mail.gmail.com> <4D2EDE92.40203@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
Hi John,

2011/1/13 John Crispin <blogic@openwrt.org>:
>
>>> +
>>> +/* all access to the ebu must be locked */
>>> +DEFINE_SPINLOCK(ebu_lock);
>>> +EXPORT_SYMBOL_GPL(ebu_lock);
>>>
>> This lock is only needed if you want to use software arbitration.
>> Normally the EBU does hardware arbitration and can be accessed safely
>> without lock.
>>
>>
> openwrt borks up on mini_fo init when this lock is not in-place. we saw
> a lot of issues in the past which lead to this lock being added. i will
> retry it with out the lock to verify
>
Ok I never tried mini_fo bit it's working fine with squashfs. Maybe
it's a problem with your EBU setup. We always reset
the EBU_ADDR_SEL0 and EBU_CON_0 registers in U-Boot's lowlevel_init.S.
The values are EBU_ADDR_SEL0 = 0x10000021
and EBU_CON_0 = 0x8001F7FF.
My suggestion is to wrap the locking mechanism into separate inline
functions and define them only if really needed and enabled in kernel
config.

Daniel

<Prev in Thread] Current Thread [Next in Thread>