linux-mips
[Top] [All Lists]

Re: [PATCH 06/10] MIPS: lantiq: add NOR flash support

To: Daniel Schwierzeck <daniel.schwierzeck@googlemail.com>
Subject: Re: [PATCH 06/10] MIPS: lantiq: add NOR flash support
From: John Crispin <blogic@openwrt.org>
Date: Tue, 11 Jan 2011 11:29:52 +0100
Cc: Ralf Baechle <ralf@linux-mips.org>, Ralph Hempel <ralph.hempel@lantiq.com>, David Woodhouse <dwmw2@infradead.org>, linux-mips@linux-mips.org, linux-mtd@lists.infradead.org
In-reply-to: <4D2BC787.20002@gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1294257379-417-1-git-send-email-blogic@openwrt.org> <1294257379-417-7-git-send-email-blogic@openwrt.org> <4D2BC787.20002@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.12) Gecko/20100913 Icedove/3.0.7
On 11/01/11 03:59, Daniel Schwierzeck wrote:
> Hi John,
>
> the EBU doesn't allow unaligned read or write access thus Lantiq added
> this alignment hack directly in hardware. The addr^=2 is only needed
> during CFI probe because odd addresses are accessed. A simple solution
> is inside your patch.
>
> The spin_lock_irqsave(&ebu_lock, flags); is actually not needed
> because the EBU does access arbitration and protection already in
> hardware.
>
> Daniel
>
Hi Daniel,

thx, i will try it out later on and then merge it into v2 of the series.

John

<Prev in Thread] Current Thread [Next in Thread>