linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Use WARN() in uasm for better diagnostics.

To: Sergei Shtylyov <sshtylyov@mvista.com>
Subject: Re: [PATCH] MIPS: Use WARN() in uasm for better diagnostics.
From: Ralf Baechle <ralf@linux-mips.org>
Date: Tue, 28 Dec 2010 16:54:11 +0100
Cc: David Daney <ddaney@caviumnetworks.com>, linux-mips@linux-mips.org
In-reply-to: <4D1A05D9.9050707@mvista.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1293502709-11454-1-git-send-email-ddaney@caviumnetworks.com> <4D1A05D9.9050707@mvista.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Dec 28, 2010 at 06:44:25PM +0300, Sergei Shtylyov wrote:

> > static inline __uasminit u32 build_jimm(u32 arg)
> > {
> >-    if (arg & ~((JIMM_MASK) << 2))
> >-            printk(KERN_WARNING "Micro-assembler field overflow\n");
> >+    WARN(arg & ~((JIMM_MASK) << 2),
> 
>    Could drop parens around JIMM_MASK while at it...

Done.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>