Re: [PATCH] MIPS: Use WARN() in uasm for better diagnostics.

linux-mips

Re: [PATCH] MIPS: Use WARN() in uasm for better diagnostics.

To:	David Daney <ddaney@caviumnetworks.com>
Subject:	Re: [PATCH] MIPS: Use WARN() in uasm for better diagnostics.
From:	Ralf Baechle <ralf@linux-mips.org>
Date:	Tue, 28 Dec 2010 16:31:07 +0100
Cc:	linux-mips@linux-mips.org
In-reply-to:	<1293502709-11454-1-git-send-email-ddaney@caviumnetworks.com>
Original-recipient:	rfc822;linux-mips@linux-mips.org
References:	<1293502709-11454-1-git-send-email-ddaney@caviumnetworks.com>
Sender:	linux-mips-bounce@linux-mips.org
User-agent:	Mutt/1.5.21 (2010-09-15)

On Mon, Dec 27, 2010 at 06:18:29PM -0800, David Daney wrote:

> On the off chance that uasm ever warns about overflow, there is no way
> to know what the offending instruction is.
> 
> Change the printks to WARNs, so we can get a nice stack trace.  It has
> the added benefit of being much more noticeable than the short single
> line warning message, so is less likely to be ignored.

Time to interrupt vacation for some patches :-)

Queued for 2.6.38.  Thanks!

  Ralf

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] MIPS: Use WARN() in uasm for better diagnostics., David Daney Re: [PATCH] MIPS: Use WARN() in uasm for better diagnostics., Ralf Baechle <= Re: [PATCH] MIPS: Use WARN() in uasm for better diagnostics., Sergei Shtylyov Re: [PATCH] MIPS: Use WARN() in uasm for better diagnostics., Ralf Baechle

Previous by Date:	Re: SMTC support status in latest git head., Kevin D. Kissell
Next by Date:	Re: [PATCH] MIPS: Use WARN() in uasm for better diagnostics., Sergei Shtylyov
Previous by Thread:	[PATCH] MIPS: Use WARN() in uasm for better diagnostics., David Daney
Next by Thread:	Re: [PATCH] MIPS: Use WARN() in uasm for better diagnostics., Sergei Shtylyov
Indexes:	[Date] [Thread] [Top] [All Lists]