linux-mips
[Top] [All Lists]

Re: [PATCH V2] MIPS: Alchemy: fix build with SERIAL_8250=n

To: Manuel Lauss <manuel.lauss@googlemail.com>
Subject: Re: [PATCH V2] MIPS: Alchemy: fix build with SERIAL_8250=n
From: Ralf Baechle <ralf@linux-mips.org>
Date: Fri, 10 Dec 2010 20:40:52 +0000
Cc: Linux-MIPS <linux-mips@linux-mips.org>
In-reply-to: <1288025051-17145-1-git-send-email-manuel.lauss@googlemail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1288025051-17145-1-git-send-email-manuel.lauss@googlemail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Oct 25, 2010 at 06:44:11PM +0200, Manuel Lauss wrote:

> In commit 7d172bfe ("Alchemy: Add UART PM methods") I introduced
> platform PM methods which call a function of the 8250 driver;
> this patch works around link failures when the kernel is built
> without 8250 support.
> 
> Signed-off-by: Manuel Lauss <manuel.lauss@googlemail.com>
> ---
> V2: added commit name to patch description as per Sergei's suggestion.

Applied, thanks.

Though anything like a CONFIG_SERIAL_8250 in board code always strikes me
as wrong.  What if the driver is built as a module?  What if the kernel is
built without the driver, then later on the module is built separately and
then inserted?

  Ralf

<Prev in Thread] Current Thread [Next in Thread>