linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Fix build failure for IP22

To: Dmitri Vorobiev <dmitri.vorobiev@movial.com>
Subject: Re: [PATCH] MIPS: Fix build failure for IP22
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 9 Dec 2010 18:46:38 +0000
Cc: linux-mips@linux-mips.org
In-reply-to: <1290511948-10347-1-git-send-email-dmitri.vorobiev@movial.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1290511948-10347-1-git-send-email-dmitri.vorobiev@movial.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Nov 23, 2010 at 01:32:28PM +0200, Dmitri Vorobiev wrote:

> Commit 48e1fd5a81416a037f5a48120bf281102f2584e2 changed the name
> of the MIPS-specific dma_cache_sync() routine by prefixing it with
> `mips_', and removed the export for its symbol. Two drivers, which
> did use dma_cache_sync(), namely, sgiseeq and sgiwd93, were not
> converted to use the new function, which led to build failure for
> the IP22 platform.
> 
> This patch fixes the build failure by fixing the call sites of
> mips_dma_cache_sync() and exporting the symbol for this routine as
> a GPL symbol. While at it, some minor changes to improve Kconfig
> help entries were done.

dma_cache_sync isn't MIPS specific - mips_dma_cache_sync is but the
function wasn't renamed everywhere.  Looking into what went wrong now
but your patch surely is not correct.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>