|To:||anoop pa <firstname.lastname@example.org>|
|Subject:||Re: [RFC 1/3] VSMP support for msp71xx family of platforms.|
|From:||Sergei Shtylyov <email@example.com>|
|Date:||Sun, 05 Dec 2010 17:00:53 +0300|
|Cc:||Ralf Baechle <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org|
|References:||<1291220307.31413.14.camel@paanoop1-desktop> <4CF78755.email@example.com> <AANLkTinkF8_2hO7Ko=S6w2NPPX8oGTcdbRyd=7N0mUbM@mail.gmail.com>|
|User-agent:||Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:184.108.40.206) Gecko/20101027 Thunderbird/3.1.6|
Hello. On 02-12-2010 20:27, anoop pa wrote:
-obj-$(CONFIG_IRQ_MSP_CIC) += msp_irq_cic.o +obj-$(CONFIG_IRQ_MSP_CIC) += msp_irq_cic.o msp_irq_per.o
What does this change have to do with the rest of the patch?
This change is required for next patch in this. series.Is this potentially wrong .
It's not wrong -- it's just that one patch needs to address one issue. Or at least you should describe all your changed in the changelog.
Do I want to move this to next patch?
I don't know what you want. :-)
+ set_vi_handler (MIPS_CPU_IPI_CALL_IRQ, ipi_call_dispatch);
Spaces between the function name and ( are not allowed -- run your patch thru scripts/checkpatch.pl.
Not sure what went wrong. I had checked it before sending .
linux.git$ ./scripts/checkpatch.pl 0001-VSMP-support-for-msp71xx-family-of-platforms.patch total: 0 errors, 0 warnings, 84 lines checked
0001-VSMP-support-for-msp71xx-family-of-platforms.patch has no obvious style problems and is ready for submission.
I'm not sure -- perhaps checkpatch.pl has stopped complaing about those spaces... but it ceratainly did in the past.
|<Prev in Thread]||Current Thread||[Next in Thread>|
|Previous by Date:||Re: [RFC 1/3] VSMP support for msp71xx family of platforms., anoop pa|
|Next by Date:||[PATCH 1/3] RTC: SMBus support for the M41T80, etc. driver, Matt Turner|
|Previous by Thread:||Re: [RFC 1/3] VSMP support for msp71xx family of platforms., anoop pa|
|Next by Thread:||[RFC 2/3] SMP support MSP CIC and PER cascaded interrupt, Anoop P A|
|Indexes:||[Date] [Thread] [Top] [All Lists]|