linux-mips
[Top] [All Lists]

Re: Build failure triggered by recordmcount

To: Arnaud Lacombe <lacombar@gmail.com>
Subject: Re: Build failure triggered by recordmcount
From: Sergei Shtylyov <sshtylyov@mvista.com>
Date: Thu, 02 Dec 2010 15:01:26 +0300
Cc: John Reiser <jreiser@bitwagon.com>, Steven Rostedt <rostedt@goodmis.org>, linux-mips@linux-mips.org, wu zhangjin <wuzhangjin@gmail.com>
In-reply-to: <AANLkTikUZ=kQbWEtSNpw27pBPX-cSs2J+NaLODHG6T7O@mail.gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <AANLkTikjbP89qp24u1Pw6zcsyV7WcYYtmR0Yt3yCaXoh@mail.gmail.com> <AANLkTim-+1csKoCc7kqXERmLZRSt9LAAB=JPK+0gaYPo@mail.gmail.com> <AANLkTikaUxKqsqXKYpETOnWAMuCi5gp30ANux0RQuK6Z@mail.gmail.com> <AANLkTinr1bU+_YCTW9xyJ9H0qiSOifBMsxC6iujszMvs@mail.gmail.com> <4CEB37F8.1050504@bitwagon.com> <AANLkTikUZ=kQbWEtSNpw27pBPX-cSs2J+NaLODHG6T7O@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.2.12) Gecko/20101027 Thunderbird/3.1.6
On 02.12.2010 7:54, Arnaud Lacombe wrote:

It looks to me like the change which introduced "virtual functions"
forgot about cross-platform endianness.  Can anyone please test this patch?
Thank you to Arnaud for supplying before+after data files do_mounts*.o.


recordmcount: Honor endianness in fn_ELF_R_INFO

---
  scripts/recordmcount.h |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/scripts/recordmcount.h b/scripts/recordmcount.h
index 58e933a..3966717 100644
--- a/scripts/recordmcount.h
+++ b/scripts/recordmcount.h
@@ -119,7 +119,7 @@ static uint_t (*Elf_r_sym)(Elf_Rel const *rp) = 
fn_ELF_R_SYM;
  static void fn_ELF_R_INFO(Elf_Rel *const rp, unsigned sym, unsigned type)
  {
-       rp->r_info = ELF_R_INFO(sym, type);
+       rp->r_info = _w(ELF_R_INFO(sym, type));
  }
  static void (*Elf_r_info)(Elf_Rel *const rp, unsigned sym, unsigned type) = 
fn_ELF_R_INFO;
  -- 1.7.3.2

This patch does not seems to have made its way up to Linus tree, has
it been picked by anyone ?

   It was not signed off, so couldn't be applied.

Thanks,
  - Arnaud

WBR, Sergei

<Prev in Thread] Current Thread [Next in Thread>