linux-mips
[Top] [All Lists]

Re: Build failure triggered by recordmcount

To: John Reiser <jreiser@bitwagon.com>
Subject: Re: Build failure triggered by recordmcount
From: Arnaud Lacombe <lacombar@gmail.com>
Date: Wed, 1 Dec 2010 23:54:58 -0500
Cc: Steven Rostedt <rostedt@goodmis.org>, linux-mips@linux-mips.org, wu zhangjin <wuzhangjin@gmail.com>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=jXbYlbYdsjXFf07Jw9rsPjbCldq3duzKx+Bb4p0gXAc=; b=SOPILWpo4GDnoD6Yk/Ak5MXsFdkvIPfOl1mTlVcDbjBoBc9b4GjT3rVT6ITNgpyQqR hB4mdSZ4EWTk4SzrT3CVkTmUhDOTpZIf9UoQSkUZL+q4FVDzwgjNV9ktFgokhUYtC1AA +0dCxVyC7hF9jfJpxrw6Co9qPVMVzNdg9Wd4Y=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=iIE8jv276gjg4rqdrXDOjjNGXYgK72FcGdneiX8LUQLmHuCytwsi0KGz2iFhp85IR8 Ppr38k1Lwthd/qy5ZfrnAtBNP9VYPksAd3iY9AYcsJVmgbyk6AHjM9ROJfdI+9smPJpt W6pqrsRXEj6wyMJWz+W4y3wxLYqi00X9E5JXw=
In-reply-to: <4CEB37F8.1050504@bitwagon.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <AANLkTikjbP89qp24u1Pw6zcsyV7WcYYtmR0Yt3yCaXoh@mail.gmail.com> <AANLkTim-+1csKoCc7kqXERmLZRSt9LAAB=JPK+0gaYPo@mail.gmail.com> <AANLkTikaUxKqsqXKYpETOnWAMuCi5gp30ANux0RQuK6Z@mail.gmail.com> <AANLkTinr1bU+_YCTW9xyJ9H0qiSOifBMsxC6iujszMvs@mail.gmail.com> <4CEB37F8.1050504@bitwagon.com>
Sender: linux-mips-bounce@linux-mips.org
Hi Folks,

On Mon, Nov 22, 2010 at 10:41 PM, John Reiser <jreiser@bitwagon.com> wrote:
> It looks to me like the change which introduced "virtual functions"
> forgot about cross-platform endianness.  Can anyone please test this patch?
> Thank you to Arnaud for supplying before+after data files do_mounts*.o.
>
>
> recordmcount: Honor endianness in fn_ELF_R_INFO
>
> ---
>  scripts/recordmcount.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/recordmcount.h b/scripts/recordmcount.h
> index 58e933a..3966717 100644
> --- a/scripts/recordmcount.h
> +++ b/scripts/recordmcount.h
> @@ -119,7 +119,7 @@ static uint_t (*Elf_r_sym)(Elf_Rel const *rp) = 
> fn_ELF_R_SYM;
>  static void fn_ELF_R_INFO(Elf_Rel *const rp, unsigned sym, unsigned type)
>  {
> -       rp->r_info = ELF_R_INFO(sym, type);
> +       rp->r_info = _w(ELF_R_INFO(sym, type));
>  }
>  static void (*Elf_r_info)(Elf_Rel *const rp, unsigned sym, unsigned type) = 
> fn_ELF_R_INFO;
>  -- 1.7.3.2
>
This patch does not seems to have made its way up to Linus tree, has
it been picked by anyone ?

Thanks,
 - Arnaud

<Prev in Thread] Current Thread [Next in Thread>