| To: | michael@ellerman.id.au |
|---|---|
| Subject: | Re: RFC: Mega rename of device tree routines from of_*() to dt_*() |
| From: | Timur Tabi <timur@freescale.com> |
| Date: | Wed, 24 Nov 2010 09:44:52 -0600 |
| Cc: | LKML <linux-kernel@vger.kernel.org>, linux-mips <linux-mips@linux-mips.org>, microblaze-uclinux@itee.uq.edu.au, devicetree-discuss@lists.ozlabs.org, linuxppc-dev list <linuxppc-dev@ozlabs.org>, sparclinux@vger.kernel.org |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:sender:received :in-reply-to:references:from:date:x-google-sender-auth:message-id :subject:to:cc:content-type; bh=izmDHcLl3LXvScpoQg5EGVu+GyLsoSJWtYXgT4sM7Hc=; b=XDJFzAdrdJOOLe/p1XAJaMtfWRe9YCixVn+8e5dMur/aXJP8v+s9WXyLQqOdM8CMAL +tOJZ2pJnWK5aZZTrfhS7k8MK3eHKYeGucsu5GhfYr0L1cRbDLdwwJOFXPIOg+AT4l/v krr0NUqZROpGylqyunjLaRD7tcNRr7Mz6ie/o= |
| Domainkey-signature: | a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; b=W2ik5UkIN9WFDmhpTVpBJ1PwvFLAMYET6qvpwjpk1bwcKQM3vgEBp7lWkIeVzvd6uw NSmHBRyMLpwctPLTC2saBlyRaWEN/IHu6/8B9AtWA7/UbHriZEiTC8IOqnbs8oaSV2dn F3SBega076dLaCKDjWsaT6UH+nB3OYjb9Y5GU= |
| In-reply-to: | <1290607413.12457.44.camel@concordia> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <1290607413.12457.44.camel@concordia> |
| Sender: | linux-mips-bounce@linux-mips.org |
On Wed, Nov 24, 2010 at 8:03 AM, Michael Ellerman <michael@ellerman.id.au> wrote: > Personally I'm a bit ambivalent about it, the OF name is a bit wrong so > it would be nice to get rid of, but it's a lot of churn. > > So I'm hoping people with either say "YES this is a great idea", or "NO > this is stupid". Well, my vote is "no". I wouldn't call it stupid, but I do think it's a bad idea. In general, I don't like renaming functions, because it causes complications with merges and porting code across kernel versions. It also forces me to re-remember things. And especially in this case, the churn is too great. You're affecting files across multiple subsystems and architectures. -- Timur Tabi Linux kernel developer at Freescale |
| Previous by Date: | RFC: Mega rename of device tree routines from of_*() to dt_*(), Michael Ellerman |
|---|---|
| Next by Date: | Re: RFC: Mega rename of device tree routines from of_*() to dt_*(), David Daney |
| Previous by Thread: | RFC: Mega rename of device tree routines from of_*() to dt_*(), Michael Ellerman |
| Next by Thread: | Re: RFC: Mega rename of device tree routines from of_*() to dt_*(), David Daney |
| Indexes: | [Date] [Thread] [Top] [All Lists] |