linux-mips
[Top] [All Lists]

Re: Build failure triggered by recordmcount

To: Steven Rostedt <rostedt@goodmis.org>
Subject: Re: Build failure triggered by recordmcount
From: wu zhangjin <wuzhangjin@gmail.com>
Date: Wed, 24 Nov 2010 17:26:11 +0800
Cc: John Reiser <jreiser@bitwagon.com>, Arnaud Lacombe <lacombar@gmail.com>, linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=Zc3zaNXM4hAdvjd/gvpCuZd07zoWdd1E5g76HUP5LbI=; b=F/9fWJaS2CJEuUfxgHDrImIF0lBVyGDeDKPDWmqun2pcABZoKOWbHw4n/fT/vd5WH6 Ur+IvQAsPjJrFveA1fQMODb1lDDpES9LuuytXqHgq29JNX5FcxGVaQ4eV4XynzhTl8MY nX0ki6hlA06cgrOWkTpMHvAl+NG0w15g8N3NU=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=YPD5ydUbBPHS0YyFHMHH2dohG+I2+dpva9+S3y48LxxNztrTAVpOO8nPGW7E1WhfTk FcoAo6mu/XCfhQjl+4mu47J32mfEz6T1LLGUIoCwD+GjY2/0Usiwc5wov8oTJXOkX/0H hsIkfFsET1i4AXZBshM9P0xLJCwkPjxDvRDFU=
In-reply-to: <1290532165.30543.374.camel@gandalf.stny.rr.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <AANLkTikjbP89qp24u1Pw6zcsyV7WcYYtmR0Yt3yCaXoh@mail.gmail.com> <AANLkTim-+1csKoCc7kqXERmLZRSt9LAAB=JPK+0gaYPo@mail.gmail.com> <AANLkTikaUxKqsqXKYpETOnWAMuCi5gp30ANux0RQuK6Z@mail.gmail.com> <AANLkTinr1bU+_YCTW9xyJ9H0qiSOifBMsxC6iujszMvs@mail.gmail.com> <4CEB37F8.1050504@bitwagon.com> <1290532165.30543.374.camel@gandalf.stny.rr.com>
Sender: linux-mips-bounce@linux-mips.org
On Wed, Nov 24, 2010 at 1:09 AM, Steven Rostedt <rostedt@goodmis.org> wrote:
> On Mon, 2010-11-22 at 19:41 -0800, John Reiser wrote:
>> It looks to me like the change which introduced "virtual functions"
>> forgot about cross-platform endianness.  Can anyone please test this patch?
>> Thank you to Arnaud for supplying before+after data files do_mounts*.o.
>>
>>
>> recordmcount: Honor endianness in fn_ELF_R_INFO
>
> Arnaud, can I get a "Tested-by" from you.
>
> Wu, can you give me your Acked-by:

Acked-by: Wu Zhangjin <wuzhangjin@gmail.com>

Thanks & Regards,
Wu Zhangjin

>
> Thanks,
>
> -- Steve
>
>>
>> ---
>>  scripts/recordmcount.h |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/scripts/recordmcount.h b/scripts/recordmcount.h
>> index 58e933a..3966717 100644
>> --- a/scripts/recordmcount.h
>> +++ b/scripts/recordmcount.h
>> @@ -119,7 +119,7 @@ static uint_t (*Elf_r_sym)(Elf_Rel const *rp) = 
>> fn_ELF_R_SYM;
>>   static void fn_ELF_R_INFO(Elf_Rel *const rp, unsigned sym, unsigned type)
>>  {
>> -     rp->r_info = ELF_R_INFO(sym, type);
>> +     rp->r_info = _w(ELF_R_INFO(sym, type));
>>  }
>>  static void (*Elf_r_info)(Elf_Rel *const rp, unsigned sym, unsigned type) = 
>> fn_ELF_R_INFO;
>>  -- 1.7.3.2
>>
>>
>
>
>

<Prev in Thread] Current Thread [Next in Thread>