[Top] [All Lists]

Re: [PATCH 09/18] input: add input driver for polled GPIO buttons

To: Gabor Juhos <>
Subject: Re: [PATCH 09/18] input: add input driver for polled GPIO buttons
From: Ben Gardiner <>
Date: Tue, 23 Nov 2010 14:24:47 -0500
Cc: Ralf Baechle <>,,, "Luis R. Rodriguez" <>, Cliff Holden <>, Dmitry Torokhov <>, Mike Frysinger <>,
In-reply-to: <>
Original-recipient: rfc822;
References: <> <>
Hi Gabor,

On Tue, Nov 23, 2010 at 10:06 AM, Gabor Juhos <> wrote:
> The existing gpio-keys driver can be usable only for GPIO lines with
> interrupt support. Several devices have buttons connected to a GPIO
> line which is not capable to generate interrupts. This patch adds a
> new input driver using the generic GPIO layer and the input-polldev
> to support such buttons.
> Signed-off-by: Gabor Juhos <>
> Cc: Dmitry Torokhov <>
> Cc: Mike Frysinger <>
> Cc:

I'm excited to see this patch posted. As I understand it, this
"separate polling gpio button driver" approach is preferred to the
"polling extensions in gpio-keys approach". I'm sorry I missed the RFC
[1] : I posted a revised version of Alex Clouter's and Paul Mundt's
polling gpio-keys support [2]. But now I can try integrating this
driver. :)

I will be posting a version of the patch shortly that is still using
the polling-gpio-keys support -- because there are discussions in the
machine-specific parts. Then I will try to integrate this driver into
the series.

Best Regards,
Ben Gardiner


Nanometrics Inc.

<Prev in Thread] Current Thread [Next in Thread>