linux-mips
[Top] [All Lists]

Re: Build failure triggered by recordmcount

To: John Reiser <jreiser@bitwagon.com>
Subject: Re: Build failure triggered by recordmcount
From: Steven Rostedt <rostedt@goodmis.org>
Date: Tue, 23 Nov 2010 12:09:25 -0500
Cc: Arnaud Lacombe <lacombar@gmail.com>, linux-mips@linux-mips.org, wu zhangjin <wuzhangjin@gmail.com>
In-reply-to: <4CEB37F8.1050504@bitwagon.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <AANLkTikjbP89qp24u1Pw6zcsyV7WcYYtmR0Yt3yCaXoh@mail.gmail.com> <AANLkTim-+1csKoCc7kqXERmLZRSt9LAAB=JPK+0gaYPo@mail.gmail.com> <AANLkTikaUxKqsqXKYpETOnWAMuCi5gp30ANux0RQuK6Z@mail.gmail.com> <AANLkTinr1bU+_YCTW9xyJ9H0qiSOifBMsxC6iujszMvs@mail.gmail.com> <4CEB37F8.1050504@bitwagon.com>
Sender: linux-mips-bounce@linux-mips.org
On Mon, 2010-11-22 at 19:41 -0800, John Reiser wrote:
> It looks to me like the change which introduced "virtual functions"
> forgot about cross-platform endianness.  Can anyone please test this patch?
> Thank you to Arnaud for supplying before+after data files do_mounts*.o.
> 
> 
> recordmcount: Honor endianness in fn_ELF_R_INFO

Arnaud, can I get a "Tested-by" from you.

Wu, can you give me your Acked-by:

Thanks,

-- Steve

> 
> ---
>  scripts/recordmcount.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/scripts/recordmcount.h b/scripts/recordmcount.h
> index 58e933a..3966717 100644
> --- a/scripts/recordmcount.h
> +++ b/scripts/recordmcount.h
> @@ -119,7 +119,7 @@ static uint_t (*Elf_r_sym)(Elf_Rel const *rp) = 
> fn_ELF_R_SYM;
>   static void fn_ELF_R_INFO(Elf_Rel *const rp, unsigned sym, unsigned type)
>  {
> -     rp->r_info = ELF_R_INFO(sym, type);
> +     rp->r_info = _w(ELF_R_INFO(sym, type));
>  }
>  static void (*Elf_r_info)(Elf_Rel *const rp, unsigned sym, unsigned type) = 
> fn_ELF_R_INFO;
>  -- 1.7.3.2
> 
> 



<Prev in Thread] Current Thread [Next in Thread>