linux-mips
[Top] [All Lists]

Re: [PATCH] Add support for Realtek Media Player SoCs

To: Arnaud Patard <arnaud.patard@rtp-net.org>
Subject: Re: [PATCH] Add support for Realtek Media Player SoCs
From: Ralf Baechle <ralf@linux-mips.org>
Date: Mon, 22 Nov 2010 00:41:14 +0000
Cc: shmprtd@googlemail.com, linux-mips@linux-mips.org
In-reply-to: <87r5efyozy.fsf@lechat.rtp-net.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <tkrat.a6310f0563cae06d@googlemail.com> <87r5efyozy.fsf@lechat.rtp-net.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Sun, Nov 21, 2010 at 11:01:21AM +0100, Arnaud Patard wrote:

> Please read Documentation/SubmittingPatches. One big patch is just
> impossible to review (at least for me), please split it in fewer
> chunks.

This is not outrageously huge and actually well smaller than the "atoms"
some other patches were split into.  Ideally patches should be split such
that each patch fixes one bug or adds one feature and such that applying
only a part of a patch series does not result in a regression.  The
absolute size or number of patches at least to me is a secondary
consideration.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>