| To: | Deng-Cheng Zhu <dengcheng.zhu@gmail.com> |
|---|---|
| Subject: | Re: [PATCH 3/5] MIPS/Perf-events: Check event state in validate_event() |
| From: | Will Deacon <will.deacon@arm.com> |
| Date: | Fri, 19 Nov 2010 12:05:05 +0000 |
| Cc: | ralf@linux-mips.org, a.p.zijlstra@chello.nl, fweisbec@gmail.com, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, wuzhangjin@gmail.com, paulus@samba.org, mingo@elte.hu, acme@redhat.com |
| In-reply-to: | <AANLkTikdLqo0-jkLkY-jGxurKMnmv+gb0VWWDZu6TOwd@mail.gmail.com> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <1290063401-25440-1-git-send-email-dengcheng.zhu@gmail.com> <1290063401-25440-4-git-send-email-dengcheng.zhu@gmail.com> <1290159806.9342.7.camel@e102144-lin.cambridge.arm.com> <AANLkTikdLqo0-jkLkY-jGxurKMnmv+gb0VWWDZu6TOwd@mail.gmail.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
On Fri, 2010-11-19 at 11:30 +0000, Deng-Cheng Zhu wrote: > Ah, I see. Thanks for your explanation. > > But by doing this, I think we need to modify validate_group() as well. > Consider a group which has all its events either not for this PMU or in > OFF/Error state. Then the last validate_event() in validate_group() does > not work. Right? So, how about the following: [...] If none of the events are for this PMU, then our validate_group() won't be called. If all the events are OFF/ERROR then I don't see what's wrong with passing the validation. Will |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 3/5] MIPS/Perf-events: Check event state in validate_event(), Will Deacon |
|---|---|
| Next by Date: | Re: [PATCH 3/5] MIPS/Perf-events: Check event state in validate_event(), Peter Zijlstra |
| Previous by Thread: | Re: [PATCH 3/5] MIPS/Perf-events: Check event state in validate_event(), Deng-Cheng Zhu |
| Next by Thread: | [PATCH 5/5] MIPS/Perf-events: Use unsigned delta for right shift in event update, Deng-Cheng Zhu |
| Indexes: | [Date] [Thread] [Top] [All Lists] |