linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS VPE support module: don't deref potentially null pbuffe

To: Jesper Juhl <jj@chaosbits.net>
Subject: Re: [PATCH] MIPS VPE support module: don't deref potentially null pbuffer and don't do pointless null check before vfree
From: Ralf Baechle <ralf@linux-mips.org>
Date: Mon, 8 Nov 2010 22:44:04 +0000
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
In-reply-to: <alpine.LNX.2.00.1011071943460.26247@swampdragon.chaosbits.net>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <alpine.LNX.2.00.1010301823350.1572@swampdragon.chaosbits.net> <20101107142933.GA7999@linux-mips.org> <alpine.LNX.2.00.1011071943460.26247@swampdragon.chaosbits.net>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Sun, Nov 07, 2010 at 07:48:25PM +0100, Jesper Juhl wrote:

> I've taken a second look. I still have no way at all to test this, so 
> please take a close look before potentially applying it, but how does this 
> look to you?

Testing is a little tricky - it requires a MIPS 34K processor in a
configuration with more than one VPE.

> Don't dereference pbuffer before ttesting it for null.
> Don't do pointless check of pointer passed to vfree for null as vfree does 
> this itself.

I've already checked in something based on your first patch with the
other changes I suggested added.

Thanks!

  Ralf

<Prev in Thread] Current Thread [Next in Thread>