linux-mips
[Top] [All Lists]

Re: [PATCH] Enable AT_PLATFORM for Loongson 2F CPU

To: David Daney <ddaney@caviumnetworks.com>
Subject: Re: [PATCH] Enable AT_PLATFORM for Loongson 2F CPU
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 4 Nov 2010 19:29:43 +0000
Cc: Robert Millan <rmh@gnu.org>, Aurelien Jarno <aurelien@aurel32.net>, linux-mips@linux-mips.org
In-reply-to: <4CD30551.1000006@caviumnetworks.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1288873119.12965.1@thorin> <4CD2E2F7.4090701@caviumnetworks.com> <4CD2EE64.5060404@aurel32.net> <AANLkTik3SH8EmhcgY9HNQLLk9Np+E6LGo8jVoGQiQCx4@mail.gmail.com> <4CD30551.1000006@caviumnetworks.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Nov 04, 2010 at 12:11:13PM -0700, David Daney wrote:

> >Well I appreciate consistency with GCC flag names, so I'd rather keep
> >the dash, but then again it's not my decision to make.  In any case,
> >whoever commits this can adjust the name to his/her liking.
> 
> I don't like to put words into Ralf's mouth, but it is easier to
> work with patches that have been tested and are ready to go, rather
> than having to re-write everything.

Indeed.  I modify lots of patches that I can't test on my hardware
collection so any change I have to do also increases of me adding bugs.
Heck, I do most of my builds on fairly modest dual core machines so I
can't even afford test builds which is how occasionally the most stupid
errors end up getting committed.

Which is why I'm increasingly asking people to do trivial changes to
patches, not because I'm lazy.

> Some of the strings in use are "i686", "x86_64", "octeon",
> "octeon2", "PARISC", "PARISC32", tilegx-m32", "v4l", "v3l", "v4b",
> and "v3b", these last for for ARM and they don't match the GCC
> -mcpu= values.
> 
> So I guess what ever you want.

It's probably reasonable if the names don't diverge too far from each
other.  Then again with the number of cpu type synonyms accepted by gcc
that may just be wishful thinking.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>