Re: [PATCH] Enable AT_PLATFORM for Loongson 2F CPU

[Robert Millan <rmh@gnu.org>]

Hi!

David Daney a écrit :
> You are claiming that all loongson2 are loongson-2f.  Is that really
> true?  Or are there other types of loongson2 that are not loongson-2f?
>
> You need to be very careful here.  This is part of the userspace ABI, so
> if you get it wrong, you are stuck with it forever.

I'll figure out how to distinguish them and send a new patch.

> One question you didn't address is why userspace would care that it is
> running on exactly "loongson-2f" instead of just mips4.

I think Aurelien answered this.

> The __elf_platform gets converted to a directory name by ld.so, so you
> may want to choose a value without '-' in it.

Well I appreciate consistency with GCC flag names, so I'd rather keep
the dash, but then again it's not my decision to make.  In any case,
whoever commits this can adjust the name to his/her liking.

-- 
Robert Millan