linux-mips
[Top] [All Lists]

Re: [PATCH 1/3] ftrace/MIPS: Add MIPS64 support for C version of recordm

To: Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH 1/3] ftrace/MIPS: Add MIPS64 support for C version of recordmcount
From: wu zhangjin <wuzhangjin@gmail.com>
Date: Wed, 27 Oct 2010 23:59:28 +0800
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, John Reiser <jreiser@bitwagon.com>, "Maciej W. Rozycki" <macro@linux-mips.org>, David Daney <ddaney@caviumnetworks.com>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type; bh=qpgbAglK1wvNSrb7L6qCTaUZWOtrlQ8pZoUp/C1xfXo=; b=oY4eNxn7dAZy0yQCX0wzjCxvrBc3PPtuVh5bQF53n+wgpCxEHwl404MlIGdlFJNOAQ 7kB52PMQO2D5rLF5Wos0hYReOY0HyajoGRQS54h/5s0TRHav4SGkH4d2LKmRAyGD3YTI czzGW/PQeYLwL0GmFGwMcnV6pWw0WrnqQ6a10=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=LBtmP6IUtP9jLw1CIaOLGhiXBMs4HeF84b5v28roTAJzvE/Pa1yzFJrChCM/La/kbq 3kPDz6Y1G3H09nd72w3LnrphZYzDSNUpYwjM8HnwLRFAVTfUFkWVD4zi1DuJWyHbx2gB 8xUgy89xnJxQYKrfjzgiFuk63K7VZwjC4ErTI=
In-reply-to: <1288190315.18238.128.camel@gandalf.stny.rr.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <cover.1288176026.git.wuzhangjin@gmail.com> <910dc2d5ae1ed042df4f96815fe4a433078d1c2a.1288176026.git.wuzhangjin@gmail.com> <1288186366.18238.125.camel@gandalf.stny.rr.com> <AANLkTinsfveuYdo4YJGHqasPgG=+ftL-8sbC5_aYAytt@mail.gmail.com> <1288190315.18238.128.camel@gandalf.stny.rr.com>
Sender: linux-mips-bounce@linux-mips.org
On Wed, Oct 27, 2010 at 10:38 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> On Wed, 2010-10-27 at 22:09 +0800, wu zhangjin wrote:
>> On Wed, Oct 27, 2010 at 9:32 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
>> > On Wed, 2010-10-27 at 18:59 +0800, Wu Zhangjin wrote:
>> >> From: Wu Zhangjin <wuzhangjin@gmail.com>
>> >
>> > The From above states that you wrote this. Did you modify what John and
>> > Maciej did? If so, please state clearly what each author has done, and
>> > how you modified it. If you did not write this, please change the From
>> > to the correct author.
>> >
>> > If you did modify it, then state something like this in the change log.
>> >
>> > Original version written by John Reiser <jreiser@BitWagon.com>
>> >
>> > Usage of "union mips_r_info" and the functions MIPS64_r_sym() and
>> > MIPS64_r_info() written by Maciej W. Rozycki <macro@linux-mips.org>
>> >
>>
>> yeah, that is true above.
>>
>> > Then state the changes you made.
>>
>> I didn't change it, just added the comments in the patch log and tested it.
>>
>> Should I resend the patch with the change log information about John and 
>> Maciej?
>>
>
> I can make the changes.
>

ok, thanks.

> Then the patch is originally John's, right?
>

Yes, John write it.

> I'll make him the author, with the comment about Maciej, and keep you as
> the Tested-by.

ok, Macjej has simplified the r_info of MIPS there, so perhaps we need
to add SoB for him and he told me to add that line.

For me, Tested-by: is ok.

Regards,
Wu Zhangjin

<Prev in Thread] Current Thread [Next in Thread>