linux-mips
[Top] [All Lists]

[PATCH 6/14] arch/mips/pmc-sierra/yosemite/setup.c: delete double assign

To: Ralf Baechle <ralf@linux-mips.org>
Subject: [PATCH 6/14] arch/mips/pmc-sierra/yosemite/setup.c: delete double assignment
From: Julia Lawall <julia@diku.dk>
Date: Tue, 26 Oct 2010 12:25:35 +0200
Cc: kernel-janitors@vger.kernel.org, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
In-reply-to: <1288088743-3725-1-git-send-email-julia@diku.dk>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1288088743-3725-1-git-send-email-julia@diku.dk>
Sender: linux-mips-bounce@linux-mips.org
From: Julia Lawall <julia@diku.dk>

Delete successive assignments to the same location.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression i;
@@

*i = ...;
 i = ...;
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>

---
This change also makes the variable cpu_clock_freq be not used in the
current file.  If this is the correct change to plat_time_init, then
perhaps the declaration of that variable should be moved elsewhere, or the
variable should be deleted completely.

 arch/mips/pmc-sierra/yosemite/setup.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/mips/pmc-sierra/yosemite/setup.c 
b/arch/mips/pmc-sierra/yosemite/setup.c
index 3498ac9..b56a924 100644
--- a/arch/mips/pmc-sierra/yosemite/setup.c
+++ b/arch/mips/pmc-sierra/yosemite/setup.c
@@ -140,8 +140,7 @@ int rtc_mips_set_time(unsigned long tim)
 
 void __init plat_time_init(void)
 {
-       mips_hpt_frequency = cpu_clock_freq / 2;
-mips_hpt_frequency = 33000000 * 3 * 5;
+       mips_hpt_frequency = 33000000 * 3 * 5;
 }
 
 unsigned long ocd_base;


<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH 6/14] arch/mips/pmc-sierra/yosemite/setup.c: delete double assignment, Julia Lawall <=