linux-mips
[Top] [All Lists]

Re: [PATCH] of/mips: Cleanup some include directives/files.

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] of/mips: Cleanup some include directives/files.
From: Grant Likely <grant.likely@secretlab.ca>
Date: Wed, 20 Oct 2010 12:03:32 -0600
Cc: David Daney <ddaney@caviumnetworks.com>, linux-mips@linux-mips.org, devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, Dezhong Diao <dediao@cisco.com>
In-reply-to: <20101020065830.GA12565@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1287528631-31797-1-git-send-email-ddaney@caviumnetworks.com> <20101020065830.GA12565@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.20 (2009-06-14)
On Wed, Oct 20, 2010 at 07:58:30AM +0100, Ralf Baechle wrote:
> On Tue, Oct 19, 2010 at 03:50:31PM -0700, David Daney wrote:
> 
> > The __init directives should go on the definitions of things, not the
> > declaration, also __init is meaningless for inline functions, so
> > remove it from prom.h.  This allows us to get rid of a useless
> > #include, but most of the rest of them are useless too, so kill them
> > as well.
> > 
> > If of_i2c.c needs irq definitions, it should include linux/irq.h
> > directly, not assume indirect inclusion via asm/prom.h.
> 
> Grant, I assume you're going to merge this one.
> 
> Acked-by: Ralf Baechle <ralf@linux-mips.org>

Yes, I'll pick it up.  I'm compile testing now.

g.

> 
>   Ralf

<Prev in Thread] Current Thread [Next in Thread>