| To: | David Daney <ddaney@caviumnetworks.com> |
|---|---|
| Subject: | Re: [PATCH] of/mips: Cleanup some include directives/files. |
| From: | Ralf Baechle <ralf@linux-mips.org> |
| Date: | Wed, 20 Oct 2010 07:58:30 +0100 |
| Cc: | linux-mips@linux-mips.org, devicetree-discuss@lists.ozlabs.org, grant.likely@secretlab.ca, linux-kernel@vger.kernel.org, Dezhong Diao <dediao@cisco.com> |
| In-reply-to: | <1287528631-31797-1-git-send-email-ddaney@caviumnetworks.com> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <1287528631-31797-1-git-send-email-ddaney@caviumnetworks.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Tue, Oct 19, 2010 at 03:50:31PM -0700, David Daney wrote: > The __init directives should go on the definitions of things, not the > declaration, also __init is meaningless for inline functions, so > remove it from prom.h. This allows us to get rid of a useless > #include, but most of the rest of them are useless too, so kill them > as well. > > If of_i2c.c needs irq definitions, it should include linux/irq.h > directly, not assume indirect inclusion via asm/prom.h. Grant, I assume you're going to merge this one. Acked-by: Ralf Baechle <ralf@linux-mips.org> Ralf |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 1/2] MIPS: fix/enrich 34K APRP (APSP) functionalities, Deng-Cheng Zhu |
|---|---|
| Next by Date: | Re: [PATCH 1/9] MIPS: Decouple BMIPS CPU support from bcm47xx/bcm63xx SoC code, Ralf Baechle |
| Previous by Thread: | [PATCH] of/mips: Cleanup some include directives/files., David Daney |
| Next by Thread: | Re: [PATCH] of/mips: Cleanup some include directives/files., Grant Likely |
| Indexes: | [Date] [Thread] [Top] [All Lists] |