linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Add some irq definitins required by OF

To: David Daney <ddaney@caviumnetworks.com>
Subject: Re: [PATCH] MIPS: Add some irq definitins required by OF
From: Grant Likely <grant.likely@secretlab.ca>
Date: Fri, 15 Oct 2010 13:55:24 -0600
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
In-reply-to: <4CB8B070.80903@caviumnetworks.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1287090174-15601-1-git-send-email-ddaney@caviumnetworks.com> <AANLkTi=M0Fk5EGy+JB2CZcGxspv3hPde10A-R5sUs3Jq@mail.gmail.com> <4CB8B070.80903@caviumnetworks.com>
Sender: linux-mips-bounce@linux-mips.org
On Fri, Oct 15, 2010 at 1:50 PM, David Daney <ddaney@caviumnetworks.com> wrote:
> On 10/14/2010 06:27 PM, Grant Likely wrote:
>>
>> On Thu, Oct 14, 2010 at 3:02 PM, David Daney<ddaney@caviumnetworks.com>
>>  wrote:
>>>
>>> Using the forthcoming open firmware (OF) on mips patches, requires
>>> that several interrupt related definitions be added.
>>>
>>> In the future we may want to allow some sort of override for
>>> irq_create_mapping, but for now it is just supplies an identity
>>> mapping.
>>>
>>> Signed-off-by: David Daney<ddaney@caviumnetworks.com>
>>> Cc: Grant Likely<grant.likely@secretlab.ca>
>>
>> Hi David,
>>
>> If you try my current next-devicetree branch then this patch should
>> not be necessary.  I was able to build the mips patch before I posted it.
>>
>
> This is what I get building on your next-devicetree branch:
>
>  CC      drivers/of/of_i2c.o
> drivers/of/of_i2c.c: In function 'of_i2c_register_devices':
> drivers/of/of_i2c.c:70: error: implicit declaration of function
> 'irq_dispose_mapping'
>
>
> Hence the part of my patch where I added those irq_create_mapping() and
> irq_dispose_mapping() functions.

Oops, I missed that.  I obviously didn't have CONFIG_I2C enabled when
I build tested.  I'll craft a patch so that MIPS doesn't need to
define it.

g.

<Prev in Thread] Current Thread [Next in Thread>