linux-mips
[Top] [All Lists]

[PATCH 4/5] mips: fix error values in case of bad_stack

To: ralf@linux-mips.org
Subject: [PATCH 4/5] mips: fix error values in case of bad_stack
From: Al Viro <viro@ftp.linux.org.uk>
Date: Tue, 28 Sep 2010 18:50:47 +0100
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Original-recipient: rfc822;linux-mips@linux-mips.org
Resent-date: Thu, 14 Oct 2010 11:41:51 +0100
Resent-from: ralf@linux-mips.org
Resent-message-id: <20101014104151.GD28911@linux-mips.org>
Resent-to: linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
User-agent: Heirloom mailx 12.4 7/29/08
we want EFAULT, not -<syscall number>

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
 arch/mips/kernel/scall32-o32.S |    2 +-
 arch/mips/kernel/scall64-o32.S |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/mips/kernel/scall32-o32.S b/arch/mips/kernel/scall32-o32.S
index d3edb9f..da98051 100644
--- a/arch/mips/kernel/scall32-o32.S
+++ b/arch/mips/kernel/scall32-o32.S
@@ -169,7 +169,7 @@ stackargs:
         * We probably should handle this case a bit more drastic.
         */
 bad_stack:
-       negu    v0                              # error
+       li      v0, EFAULT
        sw      v0, PT_R2(sp)
        li      t0, 1                           # set error flag
        sw      t0, PT_R7(sp)
diff --git a/arch/mips/kernel/scall64-o32.S b/arch/mips/kernel/scall64-o32.S
index 7ce0a36..d2bc285 100644
--- a/arch/mips/kernel/scall64-o32.S
+++ b/arch/mips/kernel/scall64-o32.S
@@ -156,7 +156,7 @@ trace_a_syscall:
         * The stackpointer for a call with more than 4 arguments is bad.
         */
 bad_stack:
-       dnegu   v0                      # error
+       li      v0, EFAULT
        sd      v0, PT_R2(sp)
        li      t0, 1                   # set error flag
        sd      t0, PT_R7(sp)
-- 
1.5.6.5


<Prev in Thread] Current Thread [Next in Thread>