linux-mips
[Top] [All Lists]

Re: [PATCH 08/14] MIPS: Octeon: Scale Octeon2 clocks in octeon_init_cvmc

To: Sergei Shtylyov <sshtylyov@mvista.com>
Subject: Re: [PATCH 08/14] MIPS: Octeon: Scale Octeon2 clocks in octeon_init_cvmcount()
From: Ralf Baechle <ralf@linux-mips.org>
Date: Mon, 11 Oct 2010 13:31:50 +0100
Cc: David Daney <ddaney@caviumnetworks.com>, linux-mips@linux-mips.org
In-reply-to: <4CAEF427.9030608@mvista.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1286492633-26885-1-git-send-email-ddaney@caviumnetworks.com> <1286492633-26885-9-git-send-email-ddaney@caviumnetworks.com> <4CAEF427.9030608@mvista.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Oct 08, 2010 at 02:36:23PM +0400, Sergei Shtylyov wrote:

> >+    while (loops--) {
> >+            u64 ipd_clk_count = cvmx_read_csr(CVMX_IPD_CLK_COUNT);
> >+            if (rdiv != 0) {
> >+                    ipd_clk_count = ipd_clk_count * rdiv;
> 
>    Why not:
> 
>                       ipd_clk_count *= rdiv;

Not sure if it really helps readability if the lhs of the assignment is only
a simple variable.  Either way, I changed it.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>