Re: [PATCH 08/14] MIPS: Octeon: Scale Octeon2 clocks in octeon_init

To:	Sergei Shtylyov <sshtylyov@mvista.com>
Subject:	Re: [PATCH 08/14] MIPS: Octeon: Scale Octeon2 clocks in octeon_init_cvmcount()
From:	Ralf Baechle <ralf@linux-mips.org>
Date:	Mon, 11 Oct 2010 13:31:50 +0100
Cc:	David Daney <ddaney@caviumnetworks.com>, linux-mips@linux-mips.org
In-reply-to:	<4CAEF427.9030608@mvista.com>
Original-recipient:	rfc822;linux-mips@linux-mips.org
References:	<1286492633-26885-1-git-send-email-ddaney@caviumnetworks.com> <1286492633-26885-9-git-send-email-ddaney@caviumnetworks.com> <4CAEF427.9030608@mvista.com>
Sender:	linux-mips-bounce@linux-mips.org
User-agent:	Mutt/1.5.21 (2010-09-15)

On Fri, Oct 08, 2010 at 02:36:23PM +0400, Sergei Shtylyov wrote:

> >+    while (loops--) {
> >+            u64 ipd_clk_count = cvmx_read_csr(CVMX_IPD_CLK_COUNT);
> >+            if (rdiv != 0) {
> >+                    ipd_clk_count = ipd_clk_count * rdiv;
> 
>    Why not:
> 
>                       ipd_clk_count *= rdiv;

Not sure if it really helps readability if the lhs of the assignment is only
a simple variable.  Either way, I changed it.

  Ralf

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 03/14] MIPS: Octeon: Update L2 Cache code for CN63XX, (continued) [PATCH 03/14] MIPS: Octeon: Update L2 Cache code for CN63XX, David Daney Re: [PATCH 03/14] MIPS: Octeon: Update L2 Cache code for CN63XX, Ralf Baechle [PATCH 05/14] MIPS: Octeon: Handle Octeon II caches., David Daney Re: [PATCH 05/14] MIPS: Octeon: Handle Octeon II caches., Ralf Baechle [PATCH 06/14] MIPS: Octeon: Probe for Octeon II CPUs., David Daney Re: [PATCH 06/14] MIPS: Octeon: Probe for Octeon II CPUs., Ralf Baechle [PATCH 07/14] MIPS: Octeon: Enable Read Inhibit / eXecute Inhibit on Octeon II., David Daney Re: [PATCH 07/14] MIPS: Octeon: Enable Read Inhibit / eXecute Inhibit on Octeon II., Ralf Baechle [PATCH 08/14] MIPS: Octeon: Scale Octeon2 clocks in octeon_init_cvmcount(), David Daney Re: [PATCH 08/14] MIPS: Octeon: Scale Octeon2 clocks in octeon_init_cvmcount(), Sergei Shtylyov Re: [PATCH 08/14] MIPS: Octeon: Scale Octeon2 clocks in octeon_init_cvmcount(), Ralf Baechle <= Re: [PATCH 08/14] MIPS: Octeon: Scale Octeon2 clocks in octeon_init_cvmcount(), Ralf Baechle [PATCH 01/14] MIPS: Octeon: Update register definitions for CN63XX chips, David Daney Re: [PATCH 01/14] MIPS: Octeon: Update register definitions for CN63XX chips, Ralf Baechle [PATCH 09/14] MIPS: Octeon: Remove bogus code from octeon_get_clock_rate(), David Daney Re: [PATCH 09/14] MIPS: Octeon: Remove bogus code from octeon_get_clock_rate(), Ralf Baechle [PATCH 11/14] MIPS: Octeon: Use I/O clock rate for calculations., David Daney Re: [PATCH 11/14] MIPS: Octeon: Use I/O clock rate for calculations., Ralf Baechle [PATCH 10/14] MIPS: Octeon: Add octeon_get_io_clock_rate() for cn63xx, David Daney Re: [PATCH 10/14] MIPS: Octeon: Add octeon_get_io_clock_rate() for cn63xx, Ralf Baechle [PATCH 14/14] MIPS: Octeon: Apply CN63XXP1 errata workarounds., David Daney

Previous by Date:	[PATCH v3] Perf-tool/MIPS: support cross compiling of tools/perf for MIPS, Deng-Cheng Zhu
Next by Date:	Re: [PATCH 1/2] MIPS: Reinstate plat_map_dma_mem_page(), Ralf Baechle
Previous by Thread:	Re: [PATCH 08/14] MIPS: Octeon: Scale Octeon2 clocks in octeon_init_cvmcount(), Sergei Shtylyov
Next by Thread:	Re: [PATCH 08/14] MIPS: Octeon: Scale Octeon2 clocks in octeon_init_cvmcount(), Ralf Baechle
Indexes:	[Date] [Thread] [Top] [All Lists]

Re: [PATCH 08/14] MIPS: Octeon: Scale Octeon2 clocks in octeon_init_cvmc