linux-mips
[Top] [All Lists]

Re: [PATCH] serial: ioc3_serial: release resources in error return path

To: Rahul Ruikar <rahul.ruikar@gmail.com>
Subject: Re: [PATCH] serial: ioc3_serial: release resources in error return path
From: Tony Luck <tony.luck@intel.com>
Date: Fri, 1 Oct 2010 13:47:52 -0700
Cc: Pat Gefre <pfg@sgi.com>, Greg Kroah-Hartman <gregkh@suse.de>, Alan Cox <alan@linux.intel.com>, Andrew Morton <akpm@linux-foundation.org>, Tejun Heo <tj@kernel.org>, linux-mips@linux-mips.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=1aVZvLaNKCuGyucMWg4MbqNkiDe+aaUq940Vuba+w4g=; b=kmxzgpDfUqwLZpWvU1929MMvOWvggmKfGLczmMdyDAW8oYgZrSJv0aKFK0rHN4tjv/ SpxMfH0TA7wOxsp7518mXE6nQp+KvfVEWZWVWK5eeFf2dHGzo4IFoSDsoxvh7K1Wc8iq XyXHOAtBXkVCyiozSsWqWxJkA0eIz14/fFI34=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=YuxVAJbrv89GG8ZhoZM0sH+7PuRAl/HpL3WcSoLjfsNZh08DISJ/LRzKhf0bTS0cYm +gto4XAJS7gcOzzPwNY5VKCTWV30CzObXd8Xz9SIU0WJZ9Ep6ze2SO/ZLyNYnAuTt9n7 7GaZt4YEUmVbG5P9VEfH0Ki2WsAsG6hHYLuag=
In-reply-to: <1285735279-2952-1-git-send-email-rahul.ruikar@gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1285735279-2952-1-git-send-email-rahul.ruikar@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
On Tue, Sep 28, 2010 at 9:41 PM, Rahul Ruikar <rahul.ruikar@gmail.com> wrote:
> -                       goto out4;
> +                       goto out3;

> -               goto out4;
> +               goto out3;

you changed *all* uses of out4 to out3, so with this patch I see:

drivers/serial/ioc3_serial.c:2152: warning: label ‘out4’ defined but not used

So I dropped the first hunks, and changed the last one to this:

>   out4:
> +       for (cnt = 0; cnt < phys_port; cnt++)
> +               kfree(ports[cnt]);
> +
>        kfree(card_ptr);
>        return ret;

Applied with this change.

Thanks

-Tony

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH] serial: ioc3_serial: release resources in error return path, Tony Luck <=