linux-mips
[Top] [All Lists]

Re: [PATCH 3/7] leds: pwm: add a new element 'name' to platform data

To: Arun Murthy <arun.murthy@stericsson.com>
Subject: Re: [PATCH 3/7] leds: pwm: add a new element 'name' to platform data
From: Sergei Shtylyov <sshtylyov@mvista.com>
Date: Tue, 28 Sep 2010 14:43:16 +0400
Cc: lars@metafoo.de, akpm@linux-foundation.org, kernel@pengutronix.de, philipp.zabel@gmail.com, robert.jarzmik@free.fr, marek.vasut@gmail.com, eric.y.miao@gmail.com, rpurdie@rpsys.net, sameo@linux.intel.com, kgene.kim@samsung.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, STEricsson_nomadik_linux@list.st.com
In-reply-to: <1285670134-18063-4-git-send-email-arun.murthy@stericsson.com>
References: <1285670134-18063-1-git-send-email-arun.murthy@stericsson.com> <1285670134-18063-4-git-send-email-arun.murthy@stericsson.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.2.9) Gecko/20100915 Thunderbird/3.1.4
Hello.

On 28-09-2010 14:35, Arun Murthy wrote:

A new element 'name' is added to pwm led platform data structure.
This is required to identify the pwm device.

Signed-off-by: Arun Murthy<arun.murthy@stericsson.com>
Acked-by: Linus Walleij<linus.walleij@stericsson.com>

[...]

diff --git a/include/linux/leds_pwm.h b/include/linux/leds_pwm.h
index 33a0711..7a847a0 100644
--- a/include/linux/leds_pwm.h
+++ b/include/linux/leds_pwm.h
@@ -16,6 +16,7 @@ struct led_pwm {
  struct led_pwm_platform_data {
        int                     num_leds;
        struct led_pwm  *leds;
+       char *name;
  };

   Shouldn't '*name'be aligned, at least with '*leds'?

WBR, Sergei

<Prev in Thread] Current Thread [Next in Thread>