linux-mips
[Top] [All Lists]

Re: [PATCH 7/9] swiotlb: Make bounce buffer bounds non-static.

To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Subject: Re: [PATCH 7/9] swiotlb: Make bounce buffer bounds non-static.
From: David Daney <ddaney@caviumnetworks.com>
Date: Mon, 27 Sep 2010 10:39:14 -0700
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, konrad.wilk@oracle.com, mingo@elte.hu, andre.goddard@gmail.com, konrad.wilk@oracle.com
In-reply-to: <20100927141616S.fujita.tomonori@lab.ntt.co.jp>
References: <1285281496-24696-1-git-send-email-ddaney@caviumnetworks.com> <1285282051-24907-2-git-send-email-ddaney@caviumnetworks.com> <20100927141616S.fujita.tomonori@lab.ntt.co.jp>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.11) Gecko/20100720 Fedora/3.0.6-1.fc12 Thunderbird/3.0.6
On 09/26/2010 10:20 PM, FUJITA Tomonori wrote:
On Thu, 23 Sep 2010 15:47:31 -0700
David Daney<ddaney@caviumnetworks.com>  wrote:

Octeon PCI mapping has to be established to cover the bounce buffers,
so it has to have access to the bounds.

Why can't you use swiotlb_init_with_tbl() instead?


Yes, as pointed out be several people, that would be better.

The swiotlb_init_with_tbl() didn't exist in earlier kernel versions and this simplification was missed when I forward ported the patch set.

By using this function, I think the entire patch set will be MIPS specific, making it unnecessary to touch the generic swiotlb code.

Thanks,
David Daney

<Prev in Thread] Current Thread [Next in Thread>