Re: [PATCH 8/9] MIPS: Add a platform hook for swiotlb setup.

To:	David Daney <ddaney@caviumnetworks.com>
Subject:	Re: [PATCH 8/9] MIPS: Add a platform hook for swiotlb setup.
From:	Ralf Baechle <ralf@linux-mips.org>
Date:	Fri, 24 Sep 2010 17:32:14 +0100
Cc:	Sergei Shtylyov <sshtylyov@mvista.com>, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
In-reply-to:	<4C9CCE42.3030309@caviumnetworks.com>
References:	<1285281496-24696-1-git-send-email-ddaney@caviumnetworks.com> <1285281496-24696-9-git-send-email-ddaney@caviumnetworks.com> <4C9CCD1B.506@mvista.com> <4C9CCE42.3030309@caviumnetworks.com>
Sender:	linux-mips-bounce@linux-mips.org
User-agent:	Mutt/1.5.20 (2009-12-10)

On Fri, Sep 24, 2010 at 09:13:54AM -0700, David Daney wrote:

> >>+#ifdef CONFIG_SWIOTLB
> >>+ plat_swiotlb_setup();
> >>+#endif
> >
> >We should avoid #ifdef's in function bodies. Why not defile an empty
> >'inline' in the header above if CONFIG_SWIOTLB is not defined?
> >
> 
> Good idea.  I will wait several days and collect any more feedback
> and generate a new patch set.

I'd also wait for a few more days so interested parties outside of the MIPS
world will have a chance to comment.

  Ralf

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 3/9] MIPS: Octeon: Adjust top of DMA32 zone., (continued) [PATCH 3/9] MIPS: Octeon: Adjust top of DMA32 zone., David Daney [PATCH 4/9] MIPS: Octeon: Select ZONE_DMA32, David Daney [PATCH 5/9] MIPS: Convert DMA to use dma-mapping-common.h, David Daney [PATCH] MIPS: Remove plat_map_dma_mem_page()., David Daney Re: [PATCH 5/9] MIPS: Convert DMA to use dma-mapping-common.h, FUJITA Tomonori Re: [PATCH 5/9] MIPS: Convert DMA to use dma-mapping-common.h, David Daney Re: [PATCH 5/9] MIPS: Convert DMA to use dma-mapping-common.h, FUJITA Tomonori [PATCH 8/9] MIPS: Add a platform hook for swiotlb setup., David Daney Re: [PATCH 8/9] MIPS: Add a platform hook for swiotlb setup., Sergei Shtylyov Re: [PATCH 8/9] MIPS: Add a platform hook for swiotlb setup., David Daney Re: [PATCH 8/9] MIPS: Add a platform hook for swiotlb setup., Ralf Baechle <= [PATCH 9/9] MIPS: Octeon: Rewrite DMA mapping functions., David Daney [PATCH] MIPS: Octeon: Remove plat_map_dma_mem_page()., David Daney [PATCH 6/9] swiotlb: Declare swiotlb_init_with_default_size(), David Daney Re: [PATCH 6/9] swiotlb: Declare swiotlb_init_with_default_size(), Konrad Rzeszutek Wilk [PATCH 7/9] swiotlb: Make bounce buffer bounds non-static., David Daney Re: [PATCH 7/9] swiotlb: Make bounce buffer bounds non-static., FUJITA Tomonori Re: [PATCH 7/9] swiotlb: Make bounce buffer bounds non-static., David Daney

Previous by Date:	Re: [PATCH 8/9] MIPS: Add a platform hook for swiotlb setup., David Daney
Next by Date:	[61/68] MIPS: Set io_map_base for several PCI bridges lacking it, Greg KH
Previous by Thread:	Re: [PATCH 8/9] MIPS: Add a platform hook for swiotlb setup., David Daney
Next by Thread:	[PATCH 9/9] MIPS: Octeon: Rewrite DMA mapping functions., David Daney
Indexes:	[Date] [Thread] [Top] [All Lists]