linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Make EARLY_PRINTK selectable for !EMBEDDED

To: David Daney <ddaney@caviumnetworks.com>
Subject: Re: [PATCH] MIPS: Make EARLY_PRINTK selectable for !EMBEDDED
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Wed, 22 Sep 2010 19:16:17 +0200
Cc: wuzhangjin@gmail.com, linux-mips@linux-mips.org, ralf@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=MYfrTL9Mf0jqxdZ7TY0xlBnTA6Jy5fUNbUi4mBFZauI=; b=dy8XXLppDJID3QtkFjv406Osy+1IwNtKQ3AR93dW7UX4BWqtU/scEmACPBFW8gZ4tv /SoNPTBGVb1+JQFz80BSUKlOxOux5g6V42JiNHszHXeZbzBzm19QEwQkuOJX9aiCnvlt pVWlOxOO+Lu5Sd+o3c24gmA99MS503IgVkQ/c=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=aPx7F2INxMQ5uuUMVUVvJl9r8/BmtGg6CxEGAb8XUrokRVZonQgBlLBulv3rcrLjgy Utnam0889TkKaqjfCQpPxMBW2e9wLToenaycZdi/e/wJbDD12+8G29EZstzMj85tmQ4i 3e3dhXrJnRIQ1HnGGRWinjAsU6nAR7UatBqXA=
In-reply-to: <4C9A327E.6030109@caviumnetworks.com>
References: <1285135150-14772-1-git-send-email-wuzhangjin@gmail.com> <4C9A327E.6030109@caviumnetworks.com>
Sender: linux-mips-bounce@linux-mips.org
On Wed, Sep 22, 2010 at 18:44, David Daney <ddaney@caviumnetworks.com> wrote:
> On 09/21/2010 10:59 PM, wuzhangjin@gmail.com wrote:
>>
>> From: Wu Zhangjin<wuzhangjin@gmail.com>
>>
>> When EMBEDDED is disabled, the EARLY_PRINTK option will be hiden and we
>> have no way to disable it.
>>
>> For EARLY_PRINTK is not necessary for !EMBEDDED, we should make it
>> selectable and only enable it by default for EMBEDDED.
>>
>> Signed-off-by: Wu Zhangjin<wuzhangjin@gmail.com>
>> ---
>>  arch/mips/Kconfig.debug |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/mips/Kconfig.debug b/arch/mips/Kconfig.debug
>> index 43dc279..77eba81 100644
>> --- a/arch/mips/Kconfig.debug
>> +++ b/arch/mips/Kconfig.debug
>> @@ -7,9 +7,9 @@ config TRACE_IRQFLAGS_SUPPORT
>>  source "lib/Kconfig.debug"
>>
>>  config EARLY_PRINTK
>> -       bool "Early printk" if EMBEDDED
>> +       bool "Early printk"
>>        depends on SYS_HAS_EARLY_PRINTK
>> -       default y
>> +       default y if EMBEDDED
>
> I hate to be a pedant, but how about if we don't make it depend on EMBEDDED
> at all?  I.E. just: 'default y'

That's what it was.

> If the system has SYS_HAS_EARLY_PRINTK, the overhead of enabling
> EARLY_PRINTK is low, although it may slow down booting.  But it is really
> not at all related to EMBEDDED.

Originally, not the _value_ of EARLY_PRINTK depended on EMBEDDED,
but the option to _change_ the value.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

<Prev in Thread] Current Thread [Next in Thread>