linux-mips
[Top] [All Lists]

Re: [PATCH 01/25] arch/mips: Use static const char arrays

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH 01/25] arch/mips: Use static const char arrays
From: Joe Perches <joe@perches.com>
Date: Sat, 18 Sep 2010 16:44:59 -0700
Cc: linux-kernel@vger.kernel.org, linux-mips@linux-mips.org
In-reply-to: <20100918225447.GA4739@linux-mips.org>
References: <cover.1284406638.git.joe@perches.com> <8fcec0d2a48e806558e6bc39d5aa98518a97f8c7.1284406638.git.joe@perches.com> <20100918225447.GA4739@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
On Sat, 2010-09-18 at 23:54 +0100, Ralf Baechle wrote:
> On Mon, Sep 13, 2010 at 12:47:39PM -0700, Joe Perches wrote:
> > diff --git a/arch/mips/pnx8550/common/reset.c 
> > b/arch/mips/pnx8550/common/reset.c
> > index fadd874..e0ac0b2 100644
> > --- a/arch/mips/pnx8550/common/reset.c
> > +++ b/arch/mips/pnx8550/common/reset.c
> > @@ -27,8 +27,8 @@
> >  
> >  void pnx8550_machine_restart(char *command)
> >  {
> > -   char head[] = "************* Machine restart *************";
> > -   char foot[] = "*******************************************";
> > +   static const char head[] = "************* Machine restart 
> > *************";
> > +   static const char foot[] = 
> > "*******************************************";
> >  
> >     printk("\n\n");
> >     printk("%s\n", head);
> NAK.
> The printks should have been taken out and shot.  And while at it line
> use the space on the other side of the wall for pnx8550_machine_power_off.

Fix them up as you see fit Ralf.

I don't have the hardware and was simply moving stuff
that should be const into const ro sections.

There are a lot of defects in that file, for instance
the printks don't use KERN_<level>.

cheers, Joe


<Prev in Thread] Current Thread [Next in Thread>