linux-mips
[Top] [All Lists]

Re: [PATCH 01/25] arch/mips: Use static const char arrays

To: Joe Perches <joe@perches.com>
Subject: Re: [PATCH 01/25] arch/mips: Use static const char arrays
From: Ralf Baechle <ralf@linux-mips.org>
Date: Sat, 18 Sep 2010 23:54:47 +0100
Cc: linux-kernel@vger.kernel.org, linux-mips@linux-mips.org
In-reply-to: <8fcec0d2a48e806558e6bc39d5aa98518a97f8c7.1284406638.git.joe@perches.com>
References: <cover.1284406638.git.joe@perches.com> <8fcec0d2a48e806558e6bc39d5aa98518a97f8c7.1284406638.git.joe@perches.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.20 (2009-12-10)
On Mon, Sep 13, 2010 at 12:47:39PM -0700, Joe Perches wrote:

> diff --git a/arch/mips/pnx8550/common/reset.c 
> b/arch/mips/pnx8550/common/reset.c
> index fadd874..e0ac0b2 100644
> --- a/arch/mips/pnx8550/common/reset.c
> +++ b/arch/mips/pnx8550/common/reset.c
> @@ -27,8 +27,8 @@
>  
>  void pnx8550_machine_restart(char *command)
>  {
> -     char head[] = "************* Machine restart *************";
> -     char foot[] = "*******************************************";
> +     static const char head[] = "************* Machine restart 
> *************";
> +     static const char foot[] = 
> "*******************************************";
>  
>       printk("\n\n");
>       printk("%s\n", head);

NAK.

The printks should have been taken out and shot.  And while at it line
use the space on the other side of the wall for pnx8550_machine_power_off.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>