linux-mips
[Top] [All Lists]

Re: [PATCH 5/5] MIPS: Move FIXADDR_TOP into spaces.h

To: cernekee@gmail.com
Subject: Re: [PATCH 5/5] MIPS: Move FIXADDR_TOP into spaces.h
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Date: Tue, 07 Sep 2010 22:13:07 +0900 (JST)
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
In-reply-to: <d84f0a8caeb61c388b1145f89c879de3@localhost>
References: <d84f0a8caeb61c388b1145f89c879de3@localhost>
Sender: linux-mips-bounce@linux-mips.org
On Mon, 6 Sep 2010 21:03:52 -0700, Kevin Cernekee <cernekee@gmail.com> wrote:
> -#define FIXADDR_TOP  ((unsigned long)(long)(int)0xfffe0000)
...
> +#define FIXADDR_TOP          _AC(0xfffe0000, UL)

For 64-bit kernel, FIXADDR_TOP should be 0xfffffffffffe0000UL not
0x00000000fffe0000UL.

The magical casts are used to sign-extend the address.  Please do not
drop them.

---
Atsushi Nemoto

<Prev in Thread] Current Thread [Next in Thread>