linux-mips
[Top] [All Lists]

Re: [PATCH] mips: irq: add stackoverflow detection

To: Adam Jiang <jiang.adam@gmail.com>
Subject: Re: [PATCH] mips: irq: add stackoverflow detection
From: Sergei Shtylyov <sshtylyov@mvista.com>
Date: Thu, 26 Aug 2010 23:00:49 +0400
Cc: ralf@linux-mips.org, dmitri.vorobiev@movial.com, wuzhangjin@gmail.com, ddaney@caviumnetworks.com, peterz@infradead.org, fweisbec@gmail.com, tj@kernel.org, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
In-reply-to: <1282828755-11953-1-git-send-email-jiang.adam@gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <linux-mips@linux-mips.org> <1282828755-11953-1-git-send-email-jiang.adam@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.21 (X11/20090320)
Hello.

Adam Jiang wrote:

Add stackoverflow detection to mips arch

[...]

diff --git a/arch/mips/kernel/irq.c b/arch/mips/kernel/irq.c
index c6345f5..8fdf79e 100644
--- a/arch/mips/kernel/irq.c
+++ b/arch/mips/kernel/irq.c
@@ -151,6 +151,25 @@ void __init init_IRQ(void)
 #endif
 }
+#ifdef DEBUG_STACKOVERFLOW
+static inline void check_stack_overflow(void)
+{
+       long sp;
+
+       asm volatile("move %0, $sp" : "=r" (sp));
+       sp = sp & (THREAD_SIZE-1);
+
+       /* check for stack overflow: is there less than 2KB free? */
+       if (unlikely(sp < (sizeof(struct thread_info) + 2048))) {
+               printk("do_IRQ: stack overflow: %ld\n",
+                      sp - sizeof(struct thread_info));
+               dump_stack();
+       }
+}
+#else
+static inline void check_stack_overflow(void) {}
+#endif
+
 /*
  * do_IRQ handles all normal device IRQ's (the special
  * SMP cross-CPU interrupts have their own specific

You've dropped call check_stack_overflow() call in do_IRQ() -- was that intentional?

WBR, Sergei

<Prev in Thread] Current Thread [Next in Thread>