| To: | Ralf Baechle <ralf@linux-mips.org> |
|---|---|
| Subject: | Re: MIPS: Get rid of branches to .subsections. |
| From: | "Maciej W. Rozycki" <macro@linux-mips.org> |
| Date: | Mon, 23 Aug 2010 12:25:33 +0100 (BST) |
| Cc: | linux-mips@linux-mips.org, Paul Gortmaker <paul.gortmaker@windriver.com> |
| In-reply-to: | <20100823101257.GA19171@linux-mips.org> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <20100818124310.GA23744@linux-mips.org> <alpine.LFD.2.00.1008230139480.900@eddie.linux-mips.org> <20100823101257.GA19171@linux-mips.org> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Alpine 2.00 (LFD 1167 2008-08-23) |
On Mon, 23 Aug 2010, Ralf Baechle wrote: > > Are you sure it won't reorder anything there that actually relies on the > > atomic access to have succeeded? I suggest adding barrier() after the > > loop. > > None of the things that were touched by the code had any barrier > functionality Some of the functions such as atomic_add don't provide > memory barriers but where needed a barrier was always provided by C code > near the end of the function, for example in atomic_add_return. OK, if you are sure this is safe, then I see no problem here. Maciej |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: MIPS: Get rid of branches to .subsections., Ralf Baechle |
|---|---|
| Next by Date: | Re: Ftrace for MIPS may hang on SMP system, wu zhangjin |
| Previous by Thread: | Re: MIPS: Get rid of branches to .subsections., Ralf Baechle |
| Next by Thread: | Does Mips Linux rely on Yamon h/w initialization (other than DDR memory which is strictly necessary)?, Ardelean, Andrei |
| Indexes: | [Date] [Thread] [Top] [All Lists] |