linux-mips
[Top] [All Lists]

Re: MIPS: Get rid of branches to .subsections.

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: MIPS: Get rid of branches to .subsections.
From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Mon, 23 Aug 2010 01:54:24 +0100 (BST)
Cc: linux-mips@linux-mips.org, Paul Gortmaker <paul.gortmaker@windriver.com>
In-reply-to: <20100818124310.GA23744@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20100818124310.GA23744@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Alpine 2.00 (LFD 1167 2008-08-23)
On Wed, 18 Aug 2010, Ralf Baechle wrote:

> By rewriting the loop around all simple LL/SC blocks to C we reduce reduce
> the amount of inline assembler and at the same time allow GCC to often
> fill the branch delay slots with something sensible or whever else clever
> optimization it may have up in its sleeve.

 Are you sure it won't reorder anything there that actually relies on the 
atomic access to have succeeded?  I suggest adding barrier() after the 
loop.

  Maciej

<Prev in Thread] Current Thread [Next in Thread>