linux-mips
[Top] [All Lists]

Re: kmalloc issue on MIPS target

To: naveen yadav <yad.naveen@gmail.com>
Subject: Re: kmalloc issue on MIPS target
From: Ralf Baechle <ralf@linux-mips.org>
Date: Wed, 18 Aug 2010 15:43:01 +0100
Cc: linux-mips@linux-mips.org
In-reply-to: <AANLkTin8LLH3DkX38B93Ap0mmz4hb9e=cEo9U3ZKmavr@mail.gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <AANLkTiniH42L=-DdJ_XHOm1Uo_=YoAqE-j9Jrm45imtG@mail.gmail.com> <20100818133336.GA25740@linux-mips.org> <AANLkTin8LLH3DkX38B93Ap0mmz4hb9e=cEo9U3ZKmavr@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.20 (2009-12-10)
On Wed, Aug 18, 2010 at 07:56:16PM +0530, naveen yadav wrote:

> I will give more info.
> 
> CONFIG_MIPS_L1_CACHE_SHIFT=5
> 
> CONFIG_DMA_NONCOHERENT=y
> 
> mips 34kc is processor
> 
> and File we are using is  arch/mips/include/asm/mach-generic/kmalloc.h
> 
> #ifndef __ASM_MACH_GENERIC_KMALLOC_H
> #define __ASM_MACH_GENERIC_KMALLOC_H
> 
> 
> #ifndef CONFIG_DMA_COHERENT
> /*
>  * Total overkill for most systems but need as a safe default.
>  * Set this one if any device in the system might do non-coherent DMA.
>  */
> #define ARCH_KMALLOC_MINALIGN   128
> #endif
> 
> #endif /* __ASM_MACH_GENERIC_KMALLOC_H */
> 
> 
> So shall we make value ARCH_KMALLOC_MINALIGN   from 128 to 32. is
> there any problem ?

No, that's just what you should do.  You do that by putting a file
that defines ARCH_KMALLOC_MINALIGN into your platforms's
arch/mips/include/asm/mach-<yourplatform>/kmalloc.h just like the ip32
file from your original posting.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>