linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: remove RELOC_HIDE on __pa_symbol

To: Namhyung Kim <namhyung@gmail.com>
Subject: Re: [PATCH] MIPS: remove RELOC_HIDE on __pa_symbol
From: David Daney <david.s.daney@gmail.com>
Date: Sun, 08 Aug 2010 22:15:04 -0700
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-kernel@vger.kernel.org, David Daney <ddaney@caviumnetworks.com>, linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=/gYRndlf6WrC/riBaCbtWWeGawIEObsdB+5/4jtFqxk=; b=ZhJZ76d9SXqEnWkq99x/lhqtGlCkYeFFvAq1bWalp25HbVtfnTKAfjtIXbb6YhEvsI RO913NVAy+l1C6tOVzDinSJZFosNMxG/D6+ChQfePByvete0xbCG3VNLkF/2OcVpxWgQ 0mdt/yNYWENa0s9eZ9frfmdZGO/Lb72RXQCrk=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=o5X8c7KeO2Smtvje2x2bucOftwQlAQfzmMSkVYKcMegI3rqbE8VzmAV3Dfy9E1HRFz awb9VGL1qBlm1UeQOxsya1W5E8r9fMNeX7SoSt3uuUS+yQgzlWXv82YRB483246IxgzW DSgOxW1+SufVdujBVBY/9/NrPyHKMZvvnxa/w=
In-reply-to: <1281297456-2711-1-git-send-email-namhyung@gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1281297456-2711-1-git-send-email-namhyung@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.7) Gecko/20100720 Fedora/3.1.1-1.fc13 Thunderbird/3.1.1
 On 08/08/2010 12:57 PM, Namhyung Kim wrote:
remove unneccessary use of RELOC_HIDE(). It does simple addition of ptr and
offset and in this case (offset 0) does practically nothing. It does NOT do
anything with linker relocation.


Maybe you could explain in more detail the problems you are having with the current definition of __pa_symbol(). I would be hesitant to change this bit of black magic unless there is a concrete problem you are trying to solve.

David Daney


Signed-off-by: Namhyung Kim<namhyung@gmail.com>
---
  arch/mips/include/asm/page.h |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/mips/include/asm/page.h b/arch/mips/include/asm/page.h
index a16beaf..f7e2684 100644
--- a/arch/mips/include/asm/page.h
+++ b/arch/mips/include/asm/page.h
@@ -150,7 +150,7 @@ typedef struct { unsigned long pgprot; } pgprot_t;
      ((unsigned long)(x) - PAGE_OFFSET + PHYS_OFFSET)
  #endif
  #define __va(x)               ((void *)((unsigned long)(x) + PAGE_OFFSET - 
PHYS_OFFSET))
-#define __pa_symbol(x) __pa(RELOC_HIDE((unsigned long)(x), 0))
+#define __pa_symbol(x) __pa(x)

  #define pfn_to_kaddr(pfn)     __va((pfn)<<  PAGE_SHIFT)



<Prev in Thread] Current Thread [Next in Thread>