Re: [PATCH] MIPS: remove RELOC_HIDE on __pa_symbol

[David Daney <david.s.daney@gmail.com>]

 On 08/08/2010 12:57 PM, Namhyung Kim wrote:
> remove unneccessary use of RELOC_HIDE(). It does simple addition of ptr and
> offset and in this case (offset 0) does practically nothing. It does NOT do
> anything with linker relocation.
Maybe you could explain in more detail the problems you are having with 
the current definition of __pa_symbol().  I would be hesitant to change 
this bit of black magic unless there is a concrete problem you are 
trying to solve.
David Daney


> Signed-off-by: Namhyung Kim<namhyung@gmail.com>
> ---
>   arch/mips/include/asm/page.h |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/mips/include/asm/page.h b/arch/mips/include/asm/page.h
> index a16beaf..f7e2684 100644
> --- a/arch/mips/include/asm/page.h
> +++ b/arch/mips/include/asm/page.h
> @@ -150,7 +150,7 @@ typedef struct { unsigned long pgprot; } pgprot_t;
>       ((unsigned long)(x) - PAGE_OFFSET + PHYS_OFFSET)
>   #endif
>   #define __va(x)               ((void *)((unsigned long)(x) + PAGE_OFFSET - 
> PHYS_OFFSET))
> -#define __pa_symbol(x) __pa(RELOC_HIDE((unsigned long)(x), 0))
> +#define __pa_symbol(x) __pa(x)
>
>   #define pfn_to_kaddr(pfn)     __va((pfn)<<  PAGE_SHIFT)