linux-mips
[Top] [All Lists]

Re: [PATCH] OCTEON: workaround linking failures with gcc-4.4.x 32-bits t

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] OCTEON: workaround linking failures with gcc-4.4.x 32-bits toolchains
From: David Daney <ddaney@caviumnetworks.com>
Date: Mon, 02 Aug 2010 09:51:41 -0700
Cc: Florian Fainelli <florian@openwrt.org>, linux-mips@linux-mips.org
In-reply-to: <20100802145904.GA6123@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <201007290013.08797.florian@openwrt.org> <4C50AC0C.9010507@caviumnetworks.com> <20100802145904.GA6123@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-2.fc12 Thunderbird/3.0.4
On 08/02/2010 07:59 AM, Ralf Baechle wrote:
On Wed, Jul 28, 2010 at 03:15:40PM -0700, David Daney wrote:

executables by default, we will produce __lshrti3 in sched_clock() which is
never resolved so the kernel fails to link. Unconditionally use the inline
assembly version as suggested by David Daney, which works around the issue.

CC: David Daney<ddaney@caviumnetworks.com>
Signed-off-by: Florian Fainelli<florian@openwrt.org>

Acked-by: David Daney<ddaney@caviumnetworks.com>

Applied - but maybe we should just add lshrti3 instead?  We already have
ashldi3, ashrdi3 and lshrdi3.

Too slow I think. If we are doing 128-bit arithmetic, it should only be for tricky things that we are optimizing to go real fast. In this case, we don't want to be making function calls.

Well that is my $0.02

David Daney

<Prev in Thread] Current Thread [Next in Thread>