| To: | "Dezhong Diao (dediao)" <dediao@cisco.com> |
|---|---|
| Subject: | Re: [PATCH] MIPS: Apply kmap_high_get on DMA functions. |
| From: | Kevin Cernekee <cernekee@gmail.com> |
| Date: | Mon, 26 Jul 2010 14:54:42 -0700 |
| Cc: | linux-mips@linux-mips.org, ralf@linux-mips.org, "David VomLehn (dvomlehn)" <dvomlehn@cisco.com> |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type; bh=DydwOVXDprX2Cc9q6bwTR688qOYxKHt35jG1B3SsvSA=; b=S+KJjbC8+89samHIiL3zHZdUeS/BiT5RI1Nl3p997EOD9KMcI62/kt/b0yBGeoWTRD Ew17ZcpCvCr1uwELmRGAZu1PlbGlr5xCGK6IcTe+K0m9FdaHbj+mUIOpkceHqk5gje0e PyWZ3zk86g2tffjr56qd9qBsK/43xE7IQeZiE= |
| Domainkey-signature: | a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=W/Ca5OKkiPHWtJC8/nVnBQI4wZ9Fu4KR9Eaoqf4c40ZgCuqJWRJD1f1oB9NcEfCLGw dWC0/OvSllkjDy7jNDw1cPK9E7d18OqtXd2MXxM+sB5lNhIek+J6alyapzOv2mL3Essp KfZTrbVKBvcP7LHw8URsPNQFC/Y03OSnSJv/Y= |
| In-reply-to: | <7A9214B0DEB2074FBCA688B30B04400D013F9D97@XMB-RCD-208.cisco.com> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <AANLkTinBb3SN1DRL9Zt8Mu1fAYgsx9VRm4FwBz4oNfdq@mail.gmail.com> <7A9214B0DEB2074FBCA688B30B04400D013F9D97@XMB-RCD-208.cisco.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
On Mon, Jul 26, 2010 at 1:44 PM, Dezhong Diao (dediao) <dediao@cisco.com> wrote:
> It is not a problem our hardware supports DMA directly to high memory.
Mine too. The existing dma-default.c does not handle high pages at
all, but applying your patch did not completely solve the problem on
my setup so I think something else is still going wrong. If I figure
it out I'll post a fix.
In the meantime could you please consider adding BUG() to the else clause, e.g.
+ if (addr) {
+ addr += offset;
+ __dma_sync_virtual(addr, size, direction);
+ kunmap_high(page);
+ } else
+ BUG()
Thanks.
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH] MIPS: Decode core number for R2 CPUs., David Daney |
|---|---|
| Next by Date: | Re: Problems with BCM91125E, Maciej W. Rozycki |
| Previous by Thread: | RE: [PATCH] MIPS: Apply kmap_high_get on DMA functions., Dezhong Diao (dediao) |
| Next by Thread: | Re: [PATCH] MIPS: Octeon: Implement delays with cycle counter., Ralf Baechle |
| Indexes: | [Date] [Thread] [Top] [All Lists] |