linux-mips
[Top] [All Lists]

Re: [PATCH 03/11] arch/mips/kernel/smtc.c: formatting of pointers in pri

To: Kulikov Vasiliy <segooon@gmail.com>
Subject: Re: [PATCH 03/11] arch/mips/kernel/smtc.c: formatting of pointers in printk()
From: Ralf Baechle <ralf@linux-mips.org>
Date: Mon, 26 Jul 2010 15:04:17 +0100
Cc: kernel-janitors@vger.kernel.org, Chris Dearman <chris@mips.com>, "Robert P. J. Day" <rpjday@crashcourse.ca>, Rusty Russell <rusty@rustcorp.com.au>, André Goddard Rosa <andre.goddard@gmail.com>, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
In-reply-to: <1279130502-10777-1-git-send-email-segooon@gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1279130502-10777-1-git-send-email-segooon@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.20 (2009-08-17)
On Wed, Jul 14, 2010 at 10:01:42PM +0400, Kulikov Vasiliy wrote:

> Use %p instead of %08x in printk().

Queued for 2.6.36, thanks!

Yes, %p is prefered here.  But your log message doesn't mention that your
patch also does a functional change, it drops the 0x prefix of the printed
value ...

  Ralf

<Prev in Thread] Current Thread [Next in Thread>