linux-mips
[Top] [All Lists]

Re: [PATCH] au1000_eth: get ethernet address from platform_data

To: manuel.lauss@googlemail.com
Subject: Re: [PATCH] au1000_eth: get ethernet address from platform_data
From: David Miller <davem@davemloft.net>
Date: Thu, 22 Jul 2010 14:12:01 -0700 (PDT)
Cc: linux-mips@linux-mips.org, netdev@vger.kernel.org
In-reply-to: <1279715450-28762-1-git-send-email-manuel.lauss@googlemail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1279715450-28762-1-git-send-email-manuel.lauss@googlemail.com>
Sender: linux-mips-bounce@linux-mips.org
From: Manuel Lauss <manuel.lauss@googlemail.com>
Date: Wed, 21 Jul 2010 14:30:50 +0200

> au1000_eth uses firmware calls to get a valid MAC address, and changes
> it depending on platform device id.  This patch moves this logic out
> of the driver into the platform device registration part, where boards
> with supported chips can use whatever firmware interface they need;
> the default implementation maintains compatibility with existing,
> YAMON-based firmware.
> 
> Tested-by: Wolfgang Grandegger <wg@denx.de>
> Acked-by: Florian Fainelli <florian@openwrt.org>
> Signed-off-by: Manuel Lauss <manuel.lauss@googlemail.com>
> ---
> This patch depends on another patch to the MIPS tree to
> apply cleanly, so I'd prefer if it went in through it as well.

Ok, feel free:

Acked-by: David S. Miller <davem@davemloft.net>

<Prev in Thread] Current Thread [Next in Thread>